From: Len Brown <lenb@kernel.org>
To: Zhao Yakui <yakui.zhao@intel.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Alexey Starikovskiy <astarikovskiy@suse.de>
Subject: Re: [PATCH 07/21] ACPI EC: Fix regression due to use of uninitialized variable
Date: Fri, 07 Nov 2008 14:45:50 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.0811071445140.8189@localhost.localdomain> (raw)
In-Reply-To: <1226038422.3989.244.camel@yakui_zhao.sh.intel.com>
> > From: Alexey Starikovskiy <astarikovskiy@suse.de>
> >
> > breakage introduced by following patch
> > commit 27663c5855b10af9ec67bc7dfba001426ba21222
> > Author: Matthew Wilcox <willy@linux.intel.com>
> > Date: Fri Oct 10 02:22:59 2008 -0400
> >
> > acpi_evaluate_integer() does not clear passed variable if
> > there is an error at evaluation.
> > So if we ignore error, we must supply initialized variable.
> >
> > References: http://bugzilla.kernel.org/show_bug.cgi?id=11917
> > http://bugzilla.kernel.org/show_bug.cgi?id=11896
> The bug references for 11896 should be deleted.
> The bug for 11896 can't be resolved by this patch.
> Thanks.
amended.
thanks,
-Len
next prev parent reply other threads:[~2008-11-07 19:45 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 4:39 ACPI patches for 2.6.28-rc3 Len Brown
2008-11-07 4:39 ` [PATCH 01/21] i7300_idle: Kconfig, show menu only on x86_64 Len Brown
2008-11-07 4:39 ` [PATCH 02/21] ACPI: EC: revert msleep patch Len Brown
2008-11-07 4:39 ` [PATCH 03/21] sony-laptop: Ignore missing _DIS method on pic device Len Brown
2008-11-07 4:39 ` [PATCH 04/21] ACPI: fix de-reference bug in power resource driver Len Brown
2008-11-07 4:39 ` [PATCH 05/21] ACPI: fan: Delete the strict check in power transition Len Brown
2008-11-07 4:39 ` [PATCH 06/21] ACPI: bugfix reporting of event handler status Len Brown
2008-11-07 4:39 ` [PATCH 07/21] ACPI EC: Fix regression due to use of uninitialized variable Len Brown
2008-11-07 6:13 ` Zhao Yakui
2008-11-07 19:45 ` Len Brown [this message]
2008-11-08 14:04 ` The fatal logic error in EC write transaction(EC transaction is done in interrupt context) Zhao, Yakui
2008-11-08 15:33 ` Alexey Starikovskiy
2008-11-08 15:58 ` Zhao, Yakui
2008-11-08 16:47 ` Alexey Starikovskiy
2008-11-08 18:42 ` [PATCH] ACPI: EC: wait for last write gpe Alexey Starikovskiy
2008-11-09 12:45 ` Zhao Yakui
2008-11-09 13:11 ` The fatal logic error in EC write transaction(EC transaction is done in interrupt context) Zhao Yakui
2008-11-09 15:27 ` Spreading FUD [was: The fatal logic error in EC write transaction(EC transaction is done in interrupt context)] Alexey Starikovskiy
2008-11-10 1:01 ` Zhao Yakui
2008-11-10 18:48 ` Alexey Starikovskiy
2008-11-07 4:39 ` [PATCH 08/21] intel_menlow: don't set max_state a negative value Len Brown
2008-11-07 4:39 ` [PATCH 09/21] ACPI: remove comments about debug layer/level to use Len Brown
2008-11-07 4:39 ` [PATCH 10/21] ACPI: SBS: remove useless acpi_cm_sbs_init() initcall Len Brown
2008-11-07 4:39 ` [PATCH 11/21] ACPI: remove CONFIG_ACPI_POWER Len Brown
2008-11-07 4:39 ` [PATCH 12/21] ACPI: remove CONFIG_ACPI_EC Len Brown
2008-11-07 4:39 ` [PATCH 13/21] intel_menlow: Add comment documenting legal GTHS values Len Brown
2008-11-07 4:39 ` [PATCH 14/21] intel_menlow: MAINTAINERS Len Brown
2008-11-07 4:39 ` [PATCH 15/21] Revert "ACPI: Ingore the RESET_REG_SUP bit when using ACPI reset mechanism" Len Brown
2008-11-07 4:39 ` [PATCH 16/21] PNP: add Bjorn Helgaas as PNP co-maintainer Len Brown
2008-11-07 4:39 ` [PATCH 17/21] ACPI: struct device - replace bus_id with dev_name(), dev_set_name() Len Brown
2008-11-07 4:39 ` [PATCH 18/21] fujitsu-laptop: fix section mismatch warning Len Brown
2008-11-07 4:39 ` [PATCH 19/21] ACPI: use macro to replace hard number Len Brown
2008-11-07 4:39 ` [PATCH 20/21] ACPI: avoid empty file name in sysfs Len Brown
2008-11-07 4:39 ` [PATCH 21/21] ACPI: EC: make kernel messages more useful when GPE storm is detected Len Brown
2008-11-07 9:18 ` Alan Jenkins
2008-11-07 13:54 ` Rafael J. Wysocki
2008-11-07 18:49 ` [stable] " Greg KH
2008-11-07 22:15 ` Rafael J. Wysocki
2008-11-11 21:23 ` Greg KH
2008-11-12 23:34 ` Rafael J. Wysocki
2008-11-13 21:46 ` Greg KH
2008-11-07 17:41 ` ACPI patches for 2.6.28-rc3 Andrey Borzenkov
2008-11-08 2:48 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0811071445140.8189@localhost.localdomain \
--to=lenb@kernel.org \
--cc=astarikovskiy@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox