public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Mark Lord <lkml@rtr.ca>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	David Brownell <david-b@pacbell.net>,
	lkml <linux-kernel@vger.kernel.org>,
	rtc-linux@googlegroups.com, linux-acpi@vger.kernel.org
Subject: Re: PATCH: /proc/acpi/alarm: handle day-of-month wraparound on readback
Date: Mon, 01 Dec 2008 13:18:50 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0812011311490.3197@localhost.localdomain> (raw)
In-Reply-To: <4934176F.6080900@rtr.ca>



On Mon, 1 Dec 2008, Mark Lord wrote:

> Fix month wrap issue with readback from /proc/acpi/alarm
> This bug has been around *forever*.
> 
> $ echo '2008-12-01 10:36:20' > /proc/acpi/alarm
> $ cat /proc/acpi/alarm
> 2008-11-01 10:36:20
> 
> Note how the readback above shows the month incorrectly.
> But with this patch applied, it shows the correct month (12).
> 
> Patch applies/works on kernels 2.6.25.* through 2.6.27.*,
> and probably on earlier kernels as well.

We've had some BCD_TO_BIN() changes here in 2.6.28 already,
does 2.6.28-rc still have this bug?

I'd check myself, but I don't have a /proc/acpi/alarm due to this:

#if defined(CONFIG_RTC_DRV_CMOS) || defined(CONFIG_RTC_DRV_CMOS_MODULE) || 
!defined(CONFIG_X86)
/* use /sys/class/rtc/rtcX/wakealarm instead; it's not ACPI-specific */
#else
#define HAVE_ACPI_LEGACY_ALARM
#endif


thanks,
-Len


  parent reply	other threads:[~2008-12-01 18:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200806222042.13929.david-b@pacbell.net>
2008-12-01 16:57 ` PATCH: /proc/acpi/alarm: handle day-of-month wraparound on readback Mark Lord
2008-12-01 17:02   ` Mark Lord
2008-12-02 10:29     ` Tino Keitel
2008-12-02 18:54       ` Mark Lord
2008-12-01 18:18   ` Len Brown [this message]
2008-12-01 22:13     ` Mark Lord
2008-12-09 15:46       ` [PATCH] " Mark Lord
2008-12-10  5:35         ` Len Brown
2008-12-01 22:15     ` PATCH: " Mark Lord
2008-12-01 22:32       ` [rtc-linux] " Alessandro Zummo
2008-12-02 18:57         ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0812011311490.3197@localhost.localdomain \
    --to=lenb@kernel.org \
    --cc=a.zummo@towertech.it \
    --cc=david-b@pacbell.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@rtr.ca \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox