From mboxrd@z Thu Jan  1 00:00:00 1970
From: Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 2.6.28-rc6] ACPICA: don't cond_resched() when
 irqs_disabled()
Date: Fri, 19 Dec 2008 00:22:06 -0500 (EST)
Message-ID: <alpine.LFD.2.00.0812190016120.6312@localhost.localdomain>
References: <20081126135508.GA1891@localhost>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Return-path: <linux-acpi-owner@vger.kernel.org>
Received: from vms173005pub.verizon.net ([206.46.173.5]:49709 "EHLO
	vms173005pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751023AbYLSFWL (ORCPT
	<rfc822;linux-acpi@vger.kernel.org>); Fri, 19 Dec 2008 00:22:11 -0500
In-reply-to: <20081126135508.GA1891@localhost>
Sender: linux-acpi-owner@vger.kernel.org
List-Id: linux-acpi@vger.kernel.org
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Alexey Starikovskiy <astarikovskiy@suse.de>, Sitsofe Wheeler <sitsofe@yahoo.com>, "Rafael J. Wysocki" <rjw@sisk.pl>, Andrew Morton <akpm@linux-foundation.org>, Linus Torvalds <torvalds@linux-foundation.org>, stable@kernel.org, linux-acpi@vger.kernel.org


On Wed, 26 Nov 2008, Wu Fengguang wrote:

> [add CC to <stable@kernel.org>, since this bug was introduced in the
> 2.6.27-rcX time frame, and should help 2.6.28 and 2.6.27.x alike]

Actually, ACPI_PREEMPTION_POINT() went in to 2.6.28-rc1,
it is not present in 2.6.27.stable so this patch
does not apply to 27.stable.

> The ACPI routines could be called from run_workqueue() with irqs disabled.
> So we should test irqs_disabled() before calling cond_resched().

I don't know how you provoked this failure.
The ACPI interpreter should always be run with interrupts enabled.
If it isn't then that is a (different) bug.

There is, however, one exception, and it is during suspend/resume;
and that _is_ a legal way to provoke this bug:

http://bugzilla.kernel.org/show_bug.cgi?id=12252

and thus the fix is actually correct, and I'll apply it.

thanks,
-- Len Brown, Intel Open Source Technology Center


> --- a/include/acpi/platform/aclinux.h
> +++ b/include/acpi/platform/aclinux.h
> @@ -141,6 +141,10 @@ static inline void *acpi_os_acquire_object(acpi_cache_t * cache)
>  /*
>   * We need to show where it is safe to preempt execution of ACPICA
>   */
> -#define ACPI_PREEMPTION_POINT()	cond_resched()
> +#define ACPI_PREEMPTION_POINT()		\
> +	do {				\
> +		if (!irqs_disabled())	\
> +			cond_resched();	\
> +	} while (0)
>  
>  #endif				/* __ACLINUX_H__ */
> --