From: Len Brown <lenb@kernel.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/2] ACPI: PCI Interrupt Links -- disable when unused
Date: Fri, 19 Dec 2008 04:33:08 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.0812190430450.1988@localhost.localdomain> (raw)
In-Reply-To: <86802c440812190110v6de03a21q4737dcc76ab6fa11@mail.gmail.com>
From: Len Brown <len.brown@intel.com>
Organization: Intel Open Source Technology Center
We start the system off with disabled links.
Here we enable the reference counting
on the links so that when drivers free IRQs
the links can return to the disabled state.
Drivers free their IRQ and reference on a link
when they unload. They may also do so upon
suspend. However, if they don't, irqrouter_resume()
will still resume any links that were
not disabled before suspend.
Signed-off-by: Len Brown <len.brown@intel.com>
---
Hmmm, look like I confused git-rebase on that one,
here it is again...
thanks,
-Len
---
drivers/acpi/pci_link.c | 11 -----------
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
index 595b131..0f7722d 100644
--- a/drivers/acpi/pci_link.c
+++ b/drivers/acpi/pci_link.c
@@ -693,18 +693,7 @@ int acpi_pci_link_free_irq(acpi_handle handle)
printk(KERN_ERR PREFIX "Link isn't initialized\n");
return -1;
}
-#ifdef FUTURE_USE
- /*
- * The Link reference count allows us to _DISable an unused link
- * and suspend time, and set it again on resume.
- * However, 2.6.12 still has irq_router.resume
- * which blindly restores the link state.
- * So we disable the reference count method
- * to prevent duplicate acpi_pci_link_set()
- * which would harm some systems
- */
link->refcnt--;
-#endif
ACPI_DEBUG_PRINT((ACPI_DB_INFO,
"Link %s is dereferenced %d\n",
acpi_device_bid(link->device), link->refcnt));
--
1.6.1.rc3.35.gc0ceb
next prev parent reply other threads:[~2008-12-19 9:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 8:22 _DIS ACPI PCI Interrupt Links Len Brown
2008-12-19 8:22 ` [PATCH 1/2] ACPI: update pci_link debug messages Len Brown
2008-12-19 8:22 ` [PATCH 2/2] ACPI: PCI Interrupt Links -- disable when unused Len Brown
2008-12-19 9:10 ` Yinghai Lu
2008-12-19 9:33 ` Len Brown [this message]
2008-12-19 11:57 ` Yinghai Lu
2008-12-19 18:39 ` Len Brown
2008-12-19 20:21 ` Yinghai Lu
2009-01-09 6:55 ` why kexec (was Re: [PATCH 2/2] ACPI: PCI Interrupt Links -- disable when unused) Len Brown
2009-01-09 7:24 ` Yinghai Lu
2009-01-09 10:30 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0812190430450.1988@localhost.localdomain \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox