Re: [PATCH 01/15] ACPI: create kernel/acpi/

[Len Brown <lenb@kernel.org>]

On Wed, 31 Dec 2008, Sam Ravnborg wrote:

> > diff --git a/kernel/acpi/Makefile b/kernel/acpi/Makefile
> > new file mode 100644
> > index 0000000..92a1f94
> > --- /dev/null
> > +++ b/kernel/acpi/Makefile
> > @@ -0,0 +1,26 @@
> > +#
> > +# Makefile for the Linux/ACPI
> > +#
> > +
> > +export ACPI_CFLAGS
> > +
> 
> Why is ACPI_CFLAGS exported?

Dunno what export actually does -- drivers/acpi/Makefile
has been this way for many years.

I believe that -Os is the right way to build the ACPI code.

I see that src/Makefile now has

ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
KBUILD_CFLAGS   += -Os
else
KBUILD_CFLAGS   += -O2
endif

so maybe we are now being redundant?

> > +ACPI_CFLAGS	:= -Os
> > +
> > +ifdef CONFIG_ACPI_DEBUG
> > +  ACPI_CFLAGS	+= -DACPI_DEBUG_OUTPUT
> > +endif
> > +
> > +EXTRA_CFLAGS	+= $(ACPI_CFLAGS)

> A better way:
> 
> ccflags-$(CONFIG_ACPI_DEBUG) := -DACPI_DEBUG_OUTPUT
> 
> Note: EXTRA_CFLAGS is deprecated in favour of ccflags-y.

can do.

thanks,
Len Brown, Intel Open Source Technology Center