From mboxrd@z Thu Jan 1 00:00:00 1970 From: Len Brown Subject: Re: [PATCH 03/15] ACPICA: move common private headers under kernel/acpi/acpica/ Date: Fri, 02 Jan 2009 16:56:32 -0500 (EST) Message-ID: References: <526647e1bb69fd3248558fce365bb1fbfb226ccd.1230719795.git.len.brown@intel.com> <20090102191451.GB14249@elte.hu> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from vms173005pub.verizon.net ([206.46.173.5]:37376 "EHLO vms173005pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758114AbZABV4w (ORCPT ); Fri, 2 Jan 2009 16:56:52 -0500 In-reply-to: <20090102191451.GB14249@elte.hu> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Ingo Molnar Cc: linux-acpi@vger.kernel.org, Linux Kernel Mailing List , Andrew Morton , Linus Torvalds , "H. Peter Anvin" , Thomas Gleixner -- Len Brown, Intel Open Source Technology Center > Random example - i dont think stuff like this is readable [in to-be > kernel/acpi/utilities/utcache.c]: > > if (cache->current_depth >= cache->max_depth) { > ACPI_FREE(object); > ACPI_MEM_TRACKING(cache->total_freed++); > } > > /* Otherwise put this object back into the cache */ > > else { > status = acpi_ut_acquire_mutex(ACPI_MTX_CACHES); > if (ACPI_FAILURE(status)) { > return (status); > } Oops, I notice that I skipped over this comment. It is a good example of needed cleanup. (I proposed moving this to kernel/acpi/acpica/, not kernel/acpi/utilities/) But the Linux kernel doesn't compile the contents of utcache.c and indeed, I should delete that entire file from the tree. Linux compiles this in osl.c instead: acpi_status acpi_os_release_object(acpi_cache_t * cache, void *object) { kmem_cache_free(cache, object); return (AE_OK); } thanks for pointing this out, I'll deal with it right now. -Len