From: Len Brown <lenb@kernel.org>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Song, Youquan" <youquan.song@intel.com>
Subject: RE: [patch 2/6] acpi: check _PSS invalidation when BIOS report _PSS with 0x80000000
Date: Fri, 09 Jan 2009 16:52:14 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.0901091649400.20020@localhost.localdomain> (raw)
In-Reply-To: <7E82351C108FA840AB1866AC776AEC4643B5888C@orsmsx505.amr.corp.intel.com>
> >> I recall nacking this one some time ago.
> >
> >Well please treat it as a bug report then. "the kernel will boot
> >crash when load cpufreq govenors". Bad!
> >
>
> I think this should be a special case even when it is not defined in spec.
>
> There is BIOS code out there that is giving 0x80000000 and Linux fails to
> boot on these systems, where as the other OS does not. Existence of even one
> such system means that the code will surely be copied onto other BIOSes and
> I don't think we can persuade BIOS guys to change this.
Let me be clear.
I agree that this needs to be fixed.
My point is that this patch is the wrong way to do it.
We need to become hardened to total garbage in this field,
or we need to do a better job of sanity checking it rather
than checking one particular bit (of many) that may be bogus.
thanks,
-Len
Intel Open Source Technology Center
next prev parent reply other threads:[~2009-01-09 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 20:17 [patch 2/6] acpi: check _PSS invalidation when BIOS report _PSS with 0x80000000 akpm
2009-01-09 21:01 ` Len Brown
2009-01-09 21:23 ` Andrew Morton
2009-01-09 21:31 ` Pallipadi, Venkatesh
2009-01-09 21:52 ` Len Brown [this message]
2009-01-09 21:34 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0901091649400.20020@localhost.localdomain \
--to=lenb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox