From: Len Brown <lenb@kernel.org>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: len.brown@intel.com, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] fix X[ ARRAY_SIZE(X) ]
Date: Sat, 17 Jan 2009 20:20:25 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.0901172020200.20606@localhost.localdomain> (raw)
In-Reply-To: <4971F06F.9030309@gmail.com>
applied
thanks,
--
Len Brown, Intel Open Source Technology Center
On Sat, 17 Jan 2009, Roel Kluin wrote:
> Ensure pcc->keymap[ ARRAY_SIZE(pcc->keymap) ] does not occur.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/platform/x86/panasonic-laptop.c b/drivers/platform/x86/panasonic-laptop.c
> index f30db36..c47a44d 100644
> --- a/drivers/platform/x86/panasonic-laptop.c
> +++ b/drivers/platform/x86/panasonic-laptop.c
> @@ -507,7 +507,7 @@ static void acpi_pcc_generate_keyinput(struct pcc_acpi *pcc)
>
> hkey_num = result & 0xf;
>
> - if (hkey_num < 0 || hkey_num > ARRAY_SIZE(pcc->keymap)) {
> + if (hkey_num < 0 || hkey_num >= ARRAY_SIZE(pcc->keymap)) {
> ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
> "hotkey number out of range: %d\n",
> hkey_num));
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2009-01-18 1:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 14:51 [PATCH] fix X[ ARRAY_SIZE(X) ] Roel Kluin
2009-01-18 1:20 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0901172020200.20606@localhost.localdomain \
--to=lenb@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox