public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Thomas Renninger <trenn@suse.de>
Cc: yakui_zhao <yakui.zhao@intel.com>,
	linux-acpi@vger.kernel.org, rui.zhang@intel.com
Subject: Re: [PATCH]: ACPI: Skip the first two elements in the _BCL package
Date: Tue, 03 Feb 2009 23:09:26 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0902032304060.5607@localhost.localdomain> (raw)
In-Reply-To: <200902031456.39680.trenn@suse.de>

> I remember that Rui pointed me to a brightness level list, which included
> a value in AC/battery values which was not in the rest of the list.

if that is true, then I like your idea better.
we should make sure that the ac and dc values appear on the list.

> I expect simply ignoring battery/AC values is not right.
> I posted a patch a while ago which did:
>   - Go through the brightness values and extract from all (including
>     AC and battery) unique values
>   - Sort them
>   - Create a with the data a new list.
> Not sure whether this would have worked, but something is still
> missing. Currently we do not use battery/AC values, but what if we want
> do that, e.g. exporting them to userspace?

I should think that it would be prudent to expose the
ac and dc defaults to user-space -- allowing user-space
to over-ride them, and then on ac events doing the
brightness switch in the kernel.  That way it will work
even w/o teaching user-space new tricks.

thanks,
-Len

> > http://bugzilla.kernel.org/show_bug.cgi?id=12450

  parent reply	other threads:[~2009-02-04  4:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-02  3:33 [PATCH]: ACPI: Skip the first two elements in the _BCL package yakui_zhao
2009-02-03  3:39 ` Len Brown
2009-02-03 13:56 ` Thomas Renninger
2009-02-04  1:50   ` yakui_zhao
2009-02-04  4:25     ` Len Brown
2009-02-04  6:06       ` yakui_zhao
2009-02-04  6:08       ` Matthew Garrett
2009-02-04  4:09   ` Len Brown [this message]
2009-02-04  6:09     ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0902032304060.5607@localhost.localdomain \
    --to=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=trenn@suse.de \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox