From: Len Brown <lenb@kernel.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/3] ACPI: processor: make new processor.h header local to driver
Date: Sat, 21 Feb 2009 22:58:51 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.0902212258220.5009@localhost.localdomain> (raw)
In-Reply-To: <20090219195148.20619.14362.stgit@bob.kio>
we already have include/acpi/processor.h,
i'd rather not also have a drivers/acpi/processor.h
--
Len Brown, Intel Open Source Technology Center
On Thu, 19 Feb 2009, Bjorn Helgaas wrote:
> The processor-related declarations in acpi_drivers.h are used
> only by the processor driver, which happens to be split across
> several files. This patch moves those declarations to a new
> drivers/acpi/processor.h file.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> ---
> drivers/acpi/processor.h | 5 +++++
> drivers/acpi/processor_core.c | 2 ++
> drivers/acpi/processor_thermal.c | 2 ++
> drivers/acpi/thermal.c | 2 ++
> include/acpi/acpi_drivers.h | 10 ----------
> 5 files changed, 11 insertions(+), 10 deletions(-)
> create mode 100644 drivers/acpi/processor.h
>
> diff --git a/drivers/acpi/processor.h b/drivers/acpi/processor.h
> new file mode 100644
> index 0000000..51df8cb
> --- /dev/null
> +++ b/drivers/acpi/processor.h
> @@ -0,0 +1,5 @@
> +#define ACPI_PROCESSOR_LIMIT_NONE 0x00
> +#define ACPI_PROCESSOR_LIMIT_INCREMENT 0x01
> +#define ACPI_PROCESSOR_LIMIT_DECREMENT 0x02
> +
> +int acpi_processor_set_thermal_limit(acpi_handle handle, int type);
> diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
> index 0cc2fd3..a744ad4 100644
> --- a/drivers/acpi/processor_core.c
> +++ b/drivers/acpi/processor_core.c
> @@ -59,6 +59,8 @@
> #include <acpi/acpi_drivers.h>
> #include <acpi/processor.h>
>
> +#include "processor.h"
> +
> #define ACPI_PROCESSOR_CLASS "processor"
> #define ACPI_PROCESSOR_DEVICE_NAME "Processor"
> #define ACPI_PROCESSOR_FILE_INFO "info"
> diff --git a/drivers/acpi/processor_thermal.c b/drivers/acpi/processor_thermal.c
> index b1eb376..a778ac2 100644
> --- a/drivers/acpi/processor_thermal.c
> +++ b/drivers/acpi/processor_thermal.c
> @@ -40,6 +40,8 @@
> #include <acpi/processor.h>
> #include <acpi/acpi_drivers.h>
>
> +#include "processor.h"
> +
> #define ACPI_PROCESSOR_CLASS "processor"
> #define _COMPONENT ACPI_PROCESSOR_COMPONENT
> ACPI_MODULE_NAME("processor_thermal");
> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> index 99e6f1f..23c5bc9 100644
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -47,6 +47,8 @@
> #include <acpi/acpi_bus.h>
> #include <acpi/acpi_drivers.h>
>
> +#include "processor.h"
> +
> #define ACPI_THERMAL_CLASS "thermal_zone"
> #define ACPI_THERMAL_DEVICE_NAME "Thermal Zone"
> #define ACPI_THERMAL_FILE_STATE "state"
> diff --git a/include/acpi/acpi_drivers.h b/include/acpi/acpi_drivers.h
> index 9ea2684..4358917 100644
> --- a/include/acpi/acpi_drivers.h
> +++ b/include/acpi/acpi_drivers.h
> @@ -103,16 +103,6 @@ extern int acpi_power_nocheck;
> int acpi_ec_ecdt_probe(void);
> int acpi_boot_ec_enable(void);
>
> -/* --------------------------------------------------------------------------
> - Processor
> - -------------------------------------------------------------------------- */
> -
> -#define ACPI_PROCESSOR_LIMIT_NONE 0x00
> -#define ACPI_PROCESSOR_LIMIT_INCREMENT 0x01
> -#define ACPI_PROCESSOR_LIMIT_DECREMENT 0x02
> -
> -int acpi_processor_set_thermal_limit(acpi_handle handle, int type);
> -
> /*--------------------------------------------------------------------------
> Dock Station
> -------------------------------------------------------------------------- */
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2009-02-22 3:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 19:51 [PATCH 0/3] ACPI: trim acpi_drivers.h Bjorn Helgaas
2009-02-19 19:51 ` [PATCH 1/3] ACPI: pci: make new pci.h header local to driver Bjorn Helgaas
2009-02-22 4:28 ` Len Brown
2009-02-24 19:06 ` Bjorn Helgaas
2009-02-26 19:45 ` Bjorn Helgaas
2009-02-19 19:51 ` [PATCH 2/3] ACPI: processor: make new processor.h " Bjorn Helgaas
2009-02-22 3:58 ` Len Brown [this message]
2009-02-19 19:51 ` [PATCH 3/3] ACPI: move internal core declarations to private header Bjorn Helgaas
2009-02-22 4:21 ` Len Brown
2009-02-24 18:51 ` Bjorn Helgaas
2009-02-26 21:00 ` Len Brown
2009-02-26 22:08 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0902212258220.5009@localhost.localdomain \
--to=lenb@kernel.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox