Re: [PATCH 4/4] asus-laptop: use select instead of depends on

[Len Brown <lenb@kernel.org>]

On Sun, 15 Feb 2009, Corentin Chary wrote:

> Like thinkpad_acpi or eeepc-laptop, asus-laptop will
> now use "select" instead of "depends on".
> 
> Signed-off-by: Corentin Chary <corentincj@iksaif.net>
> ---
>  drivers/platform/x86/Kconfig |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 6f46bc6..000a4b7 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -39,10 +39,10 @@ config ASUS_LAPTOP
>  	tristate "Asus Laptop Extras (EXPERIMENTAL)"
>  	depends on ACPI
>  	depends on EXPERIMENTAL && !ACPI_ASUS
> -	depends on LEDS_CLASS
> -	depends on NEW_LEDS
> -	depends on BACKLIGHT_CLASS_DEVICE
> -	depends on INPUT
> +	select LEDS_CLASS
> +	select NEW_LEDS

okay, i guess that is more consistent (except for ACER)

> +	select BACKLIGHT_CLASS_DEVICE

this one is a little less consistent

I should probably just whack the file to make all the drivers
do exactly the same thing with these...

> +	select INPUT

switched thta one back to "depends on INPUT"

applied.
thanks,
-Len Brown, Intel Opoen Source Technology Center

>  	---help---
>  	  This is the new Linux driver for Asus laptops. It may also support some
>  	  MEDION, JVC or VICTOR laptops. It makes all the extra buttons generate
> -- 
> 1.6.1.2
> 
>