Re: [PATCH] platform/x86: depends instead of select for laptop platform drivers

[Len Brown <lenb@kernel.org>]

--
Len Brown, Intel Open Source Technology Center

On Wed, 25 Feb 2009, Corentin Chary wrote:

> "I hate `select' and will gleefully leap on any s/select/depends/ patch,
> whether it works or not :)"
>   Andrew Morton
> 
> select INPUT is not needed here, because if someone doesn't want INPUT,
> he won't want these drivers either.
> 
> Signed-off-by: Corentin Chary <corentincj@iksaif.net>
> ---
>  drivers/platform/x86/Kconfig |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 7a46ed8..8cd903c 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -39,10 +39,10 @@ config ASUS_LAPTOP
>  	tristate "Asus Laptop Extras (EXPERIMENTAL)"
>  	depends on ACPI
>  	depends on EXPERIMENTAL && !ACPI_ASUS
> +	depends on INPUT
>  	select LEDS_CLASS
>  	select NEW_LEDS
>  	select BACKLIGHT_CLASS_DEVICE
> -	select INPUT
>  	---help---
>  	  This is the new Linux driver for Asus laptops. It may also support some
>  	  MEDION, JVC or VICTOR laptops. It makes all the extra buttons generate
> @@ -185,11 +185,11 @@ config SONYPI_COMPAT
>  config THINKPAD_ACPI
>  	tristate "ThinkPad ACPI Laptop Extras"
>  	depends on ACPI
> +	depends on INPUT
>  	select BACKLIGHT_LCD_SUPPORT
>  	select BACKLIGHT_CLASS_DEVICE
>  	select HWMON
>  	select NVRAM
> -	select INPUT
>  	select NEW_LEDS
>  	select LEDS_CLASS
>  	select NET

applied the thinkpad hunk above.
the other two were already handled previously.

all the drivers in that Kconfig now depend on INPUT, rather than selecting 
it

thanks,
Len Brown, Intel Open Source Technology Center

> @@ -307,7 +307,6 @@ config EEEPC_LAPTOP
>  	select BACKLIGHT_CLASS_DEVICE
>  	select HWMON
>  	select RFKILL
> -	select INPUT
>  	---help---
>  	  This driver supports the Fn-Fx keys on Eee PC laptops.
>  	  It also adds the ability to switch camera/wlan on/off.
> -- 
> 1.6.1.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>