From mboxrd@z Thu Jan 1 00:00:00 1970 From: Len Brown Subject: Re: [patch 4/8] acpi: get_throttling_state() cannot be larger than state_count Date: Sun, 15 Mar 2009 23:36:38 -0400 (EDT) Message-ID: References: <200903041955.n24JtRIO027997@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from vms173003pub.verizon.net ([206.46.173.3]:30987 "EHLO vms173003pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752999AbZCPDgp (ORCPT ); Sun, 15 Mar 2009 23:36:45 -0400 Received: from localhost.localdomain ([96.237.168.40]) by vms173003.mailsrvcs.net (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008; 32bit)) with ESMTPA id <0KGK00683Y133KE7@vms173003.mailsrvcs.net> for linux-acpi@vger.kernel.org; Sun, 15 Mar 2009 22:36:39 -0500 (CDT) In-reply-to: <200903041955.n24JtRIO027997@imap1.linux-foundation.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: akpm@linux-foundation.org Cc: linux-acpi@vger.kernel.org, roel.kluin@gmail.com, yakui.zhao@intel.com -- Len Brown, Intel Open Source Technology Center On Wed, 4 Mar 2009, akpm@linux-foundation.org wrote: > From: Roel Kluin > > With for(i = 0; i < n; i++) { ... } i reaches n. > > Signed-off-by: Roel Kluin > Acked-by: > Cc: Len Brown > Signed-off-by: Andrew Morton > --- > > drivers/acpi/processor_throttling.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -puN drivers/acpi/processor_throttling.c~acpi-get_throttling_state-cannot-be-larger-state_count drivers/acpi/processor_throttling.c > --- a/drivers/acpi/processor_throttling.c~acpi-get_throttling_state-cannot-be-larger-state_count > +++ a/drivers/acpi/processor_throttling.c > @@ -785,7 +785,7 @@ static int acpi_get_throttling_state(str > if (tx->control == value) > break; > } > - if (i > pr->throttling.state_count) > + if (i >= pr->throttling.state_count) > i = -1; > return i; > } > _ > how about simply... diff --git a/drivers/acpi/processor_throttling.c b/drivers/acpi/processor_throttling.c index d278381..5f09901 100644 --- a/drivers/acpi/processor_throttling.c +++ b/drivers/acpi/processor_throttling.c @@ -783,11 +783,9 @@ static int acpi_get_throttling_state(struct acpi_processor *pr, (struct acpi_processor_tx_tss *)&(pr->throttling. states_tss[i]); if (tx->control == value) - break; + return i; } - if (i > pr->throttling.state_count) - i = -1; - return i; + return -1; } static int acpi_get_throttling_value(struct acpi_processor *pr,