From: Len Brown <lenb@kernel.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: linux-acpi@vger.kernel.org, venkatesh.pallipadi@intel.com,
mingo@elte.hu, hpa@linux.intel.com, steiner@sgi.com
Subject: Re: [patch] x86, acpi: add support for x2apic ACPI extensions
Date: Fri, 27 Mar 2009 18:24:07 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0903271822190.26419@localhost.localdomain> (raw)
In-Reply-To: <1238013838.27006.435.camel@localhost.localdomain>
scripts/checkpatch.pl
ERROR: "foo * bar" should be "foo *bar"
#34: FILE: arch/x86/kernel/acpi/boot.c:233:
+acpi_parse_x2apic(struct acpi_subtable_header * header, const unsigned
long end)
WARNING: line over 80 characters
#70: FILE: arch/x86/kernel/acpi/boot.c:321:
+acpi_parse_x2apic_nmi(struct acpi_subtable_header * header, const
unsigned long end)
ERROR: "foo * bar" should be "foo *bar"
#70: FILE: arch/x86/kernel/acpi/boot.c:321:
+acpi_parse_x2apic_nmi(struct acpi_subtable_header * header, const
unsigned long end)
WARNING: line over 80 characters
#109: FILE: arch/x86/kernel/acpi/boot.c:883:
+ acpi_table_parse_madt(ACPI_MADT_TYPE_LOCAL_X2APIC_NMI,
acpi_parse_x2apic_nmi, 0);
WARNING: line over 80 characters
#169: FILE: drivers/acpi/numa.c:140:
+ "SRAT Processor
(x2apicid[0x%08x]) in proximity domain %d %s\n",
ERROR: spaces required around that '?' (ctx:VxE)
#172: FILE: drivers/acpi/numa.c:143:
+ (p->flags &
ACPI_SRAT_CPU_ENABLED)?
^
ERROR: "foo * bar" should be "foo *bar"
#194: FILE: drivers/acpi/numa.c:207:
+acpi_parse_x2apic_affinity(struct acpi_subtable_header * header,
WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(),
num_possible_cpus(), for_each_possible_cpu(), etc
#220: FILE: drivers/acpi/numa.c:287:
+ NR_CPUS);
WARNING: space prohibited between function name and open parenthesis '('
#232: FILE: include/linux/acpi.h:100:
+void acpi_numa_x2apic_affinity_init (struct acpi_srat_x2apic_cpu_affinity
*pa);
WARNING: line over 80 characters
#295: FILE: drivers/acpi/tables.c:72:
+ (p->lapic_flags & ACPI_MADT_ENABLED) ?
"enabled" : "disabled");
WARNING: line over 80 characters
#313: FILE: drivers/acpi/tables.c:137:
+ mps_inti_flags_polarity[p->inti_flags &
ACPI_MADT_POLARITY_MASK ],
ERROR: space prohibited before that close square bracket ']'
#313: FILE: drivers/acpi/tables.c:137:
+ mps_inti_flags_polarity[p->inti_flags &
ACPI_MADT_POLARITY_MASK ],
WARNING: line over 80 characters
#314: FILE: drivers/acpi/tables.c:138:
+ mps_inti_flags_trigger[(p->inti_flags &
ACPI_MADT_TRIGGER_MASK) >> 2],
total: 5 errors, 8 warnings, 259 lines checked
--
Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2009-03-27 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 20:43 [patch] x86, acpi: add support for x2apic ACPI extensions Suresh Siddha
2009-03-27 22:20 ` Len Brown
2009-04-08 16:00 ` Ingo Molnar
2009-03-27 22:24 ` Len Brown [this message]
2009-03-30 21:55 ` Suresh Siddha
2009-04-04 0:11 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0903271822190.26419@localhost.localdomain \
--to=lenb@kernel.org \
--cc=hpa@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=suresh.b.siddha@intel.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox