Re: [RESEND PATCH 0/6] ACPI video: cleanups and fixes for the recent buggy _BQC/_BCL/_BCM BIOSes

[Len Brown <lenb@kernel.org>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1399 bytes --]

On Wed, 18 Mar 2009, Zhang Rui wrote:

> Hi, all,
> 
> here is the patch set I made recently, including some cleanups and fixes
> for the Thinkpad/Asus laptops with buggy _BQC/_BCL/_BCM implementation.
> 
> The first two patches checks if ACPI video driver fails to set/get the
> current brightness level, which is not done before.
> 
> patch 3/4/5/6 are used to fix four different problems.
> 
> 1. the brightness levels when machine is on AC/Battery are not exported
>    by _BCL.
> 2. The supported brightness levels are reversed in the _BCL method.
> 3. Index values are used in _BQC/_BCL/_BCM method.
> 4. _BCQ method is implemented instead of _BQC
> 
> Any comments are welcome.

I've replaced the previous version of this series in the test tree
with this batch, and it builds.  I'll assume this is the version
you want for 2.6.30, unless I hear otherwise.

For future reference...
Please do not send patches with a "Subject:" at the start
of the body of the  message unless you really want to override
that in the e-mail Subject line...

Also, whatever you did to send 2/6, please don't do that again,
because it was the entire patch series, not just 2/6.

git format-patch; git send-email
generally get this right.
I think there are some scripts to send a quilt if you use quilt.
In general, avoid sending a patch series by hand.

thanks,
Len Brown, Intel Open Source Technology Center