Re: [PATCH] panasonic-laptop.c: add support for optical drive power control

[Len Brown <lenb@kernel.org>]

On Wed, 14 Jan 2009, Martin Lucina wrote:

> Add support for power control of the built in optical drive on models
> with the required ACPI methods present.  Tested on Panasonic CF-W4.
> 
> Creates an interface in /sys/devices/platform/panasonic/cdpower, to
> which you can write "1" to switch the drive on, "0" to switch it off
> or read from to query the current state.
> 
> Signed-off-by: Martin Lucina <mato@kotelna.sk>
> 
> ---
> 
> Harald, this should address all the comments in this thread.  I've
> removed the DMI table and enable the code if _SB.{STAT,FBAY,CDDI} are
> all present.
> 
> I've not figured out how to return an actual error from the sysfs
> show/store functions so I've at least added ACPI_DEBUG_PRINT to print an
> error if the relevant methods fail.
> 
> -mato

Harald,
It's your driver.  What do you what to do with this patch.

I'd delegate http://patchwork.kernel.org/patch/2372/
to you, but you don't seem to have a patchwork account yet.

thanks,
-Len Brown, Intel Open Source Technology Center