From mboxrd@z Thu Jan  1 00:00:00 1970
From: Len Brown <lenb@kernel.org>
Subject: Re: [patch 4/4] dell-wmi: support additional keys
Date: Wed, 15 Apr 2009 10:04:36 -0400 (EDT)
Message-ID: <alpine.LFD.2.00.0904151003001.5664@localhost.localdomain>
References: <200904110616.n3B6GXsp026164@imap1.linux-foundation.org>
 <20090413145522.GC10976@srcf.ucam.org>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Return-path: <linux-acpi-owner@vger.kernel.org>
Received: from vms173009pub.verizon.net ([206.46.173.9]:61615 "EHLO
	vms173009pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752249AbZDOOEn (ORCPT
	<rfc822;linux-acpi@vger.kernel.org>); Wed, 15 Apr 2009 10:04:43 -0400
Received: from localhost.localdomain ([96.237.168.40])
 by vms173009.mailsrvcs.net
 (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008; 32bit))
 with ESMTPA id <0KI5005KIB3RI9AN@vms173009.mailsrvcs.net> for
 linux-acpi@vger.kernel.org; Wed, 15 Apr 2009 09:04:40 -0500 (CDT)
In-reply-to: <20090413145522.GC10976@srcf.ucam.org>
Sender: linux-acpi-owner@vger.kernel.org
List-Id: linux-acpi@vger.kernel.org
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-acpi@vger.kernel.org, rafi@seas.upenn.edu, E.A.B.Piel@tudelft.nl


> > Added key codes generated by screen rotation on the Latitude XT.  0xe046
> > is sent when changing to tablet mode, and 0xe047 when it returns to
> > desktop mode.

> I don't like this - it should really be using the switch event, not 
> sending random programmable buttons.

http://patchwork.kernel.org/patch/17707/
is now set to "rejected".

thanks,
Len Brown, Intel Open Source Technology Center