Linux ACPI
 help / color / mirror / Atom feed
From: Len Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
Cc: Alan Stern
	<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Arjan van de Ven <arjan-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	yakui.zhao-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r@public.gmane.org,
	bugme-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	daniel.smoczyk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	imrehg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: [RFC PATCH] ACPI: delete obsolete "bus master activity" proc field
Date: Wed, 22 Apr 2009 19:53:11 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.0904221951550.21119@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.0904221848380.21119-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>

From: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

The legacy ACPI idle handler was deleted from 2.6.29
leaving the CPU_IDLE idle handler, which never sets bm_activity.

So delete this unused field -- it is mis-leading to have it print
all zeros when, in fact, there may bus master activity
occurring -- just that we don't track its history any more.

This patch could break something that parses
/proc/acpi/processor/*/power, since it deletes this
line from that file:

bus master activity:     00000000

Signed-off-by: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 drivers/acpi/processor_idle.c |    4 +---
 include/acpi/processor.h      |    1 -
 2 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 9d1f01e..eed3b45 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -662,11 +662,9 @@ static int acpi_processor_power_seq_show(struct seq_file *seq, void *offset)
 
 	seq_printf(seq, "active state:            C%zd\n"
 		   "max_cstate:              C%d\n"
-		   "bus master activity:     %08x\n"
 		   "maximum allowed latency: %d usec\n",
 		   pr->power.state ? pr->power.state - pr->power.states : 0,
-		   max_cstate, (unsigned)pr->power.bm_activity,
-		   pm_qos_requirement(PM_QOS_CPU_DMA_LATENCY));
+		   max_cstate, pm_qos_requirement(PM_QOS_CPU_DMA_LATENCY));
 
 	seq_puts(seq, "states:\n");
 
diff --git a/include/acpi/processor.h b/include/acpi/processor.h
index b09c4fd..4927c06 100644
--- a/include/acpi/processor.h
+++ b/include/acpi/processor.h
@@ -84,7 +84,6 @@ struct acpi_processor_power {
 	struct acpi_processor_cx *state;
 	unsigned long bm_check_timestamp;
 	u32 default_state;
-	u32 bm_activity;
 	int count;
 	struct acpi_processor_cx states[ACPI_PROCESSOR_MAX_POWER];
 	int timer_broadcast_on_state;
-- 
1.6.3.rc1.34.g0be9b


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-04-22 23:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-13145-10286@http.bugzilla.kernel.org/>
     [not found] ` <bug-13145-10286-V0hAGp6uBxO456/isadD/XN4h3HLQggn@public.gmane.org/>
2009-04-21 21:27   ` [Bugme-new] [Bug 13145] New: Processor does not go below C2 if mouse (uhci) is plugged in Andrew Morton
2009-04-21 21:40     ` Arjan van de Ven
2009-04-21 22:22     ` Oliver Neukum
2009-04-21 23:49       ` Arjan van de Ven
2009-04-22  8:48         ` Oliver Neukum
     [not found]           ` <200904221048.35180.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2009-04-22  9:12             ` Shaohua Li
     [not found]               ` <20090422091247.GA28309-U5EdaLXB8smDugQYiPIPGdh3ngVCH38I@public.gmane.org>
2009-04-22 18:35                 ` Len Brown
     [not found]     ` <20090421142751.b030cba7.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-04-22 14:51       ` Alan Stern
2009-04-22 15:09         ` Daniel Smoczyk
     [not found]           ` <d7131a800904220809ha96c0e5rd366abfcbae4d1c2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-04-22 16:39             ` Alan Stern
     [not found]         ` <Pine.LNX.4.44L0.0904221050110.3405-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2009-04-22 17:36           ` Oliver Neukum
     [not found]             ` <200904221936.38942.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2009-04-22 22:54               ` Len Brown
     [not found]                 ` <alpine.LFD.2.00.0904221848380.21119-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-04-22 23:53                   ` Len Brown [this message]
2009-04-23  0:40                 ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0904221951550.21119@localhost.localdomain \
    --to=lenb-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=arjan-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=bugme-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r@public.gmane.org \
    --cc=bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r@public.gmane.org \
    --cc=daniel.smoczyk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=imrehg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org \
    --cc=rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
    --cc=yakui.zhao-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox