From mboxrd@z Thu Jan 1 00:00:00 1970 From: Len Brown Subject: Re: 2.6.30-rc3 video/i915 build error Date: Thu, 23 Apr 2009 21:57:02 -0400 (EDT) Message-ID: References: <20090423164642.GF495@gamma.logic.tuwien.ac.at> <1240535458.3651.63.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from vms173003pub.verizon.net ([206.46.173.3]:36875 "EHLO vms173003pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751794AbZDXB5W (ORCPT ); Thu, 23 Apr 2009 21:57:22 -0400 Received: from localhost.localdomain ([96.237.168.40]) by vms173003.mailsrvcs.net (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008; 32bit)) with ESMTPA id <0KIL00DAH1F6IBZN@vms173003.mailsrvcs.net> for linux-acpi@vger.kernel.org; Thu, 23 Apr 2009 20:57:07 -0500 (CDT) In-reply-to: <1240535458.3651.63.camel@localhost.localdomain> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: yakui_zhao Cc: Norbert Preining , Jesse Barnes , Eric Anholt , "Zhang, Rui" , Keith Packard , "linux-acpi@vger.kernel.org" On Fri, 24 Apr 2009, yakui_zhao wrote: > On Fri, 2009-04-24 at 03:50 +0800, Len Brown wrote: > > Hi, Len > The issue can be fixed by the patch from Matthew. > In Matthew's patch the acpi video is also selected when the i915 is > compiled as builtin-kernel module. > But IMO this is not very good. From the Kconfig file we know that > acpi video driver depends on the following configuration: > BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL > > If the VIDEO_OUTPUT_CONTROL/BACKLIGHT_CLASS_DEVICE is not selected, > then it will still fail in kernel compilation. Matthew's patch is in. Please send me an additional patch for the additionanl failure case. thanks, Len Brown, Intel Open Source Technology Center