Linux ACPI
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Thomas Renninger <trenn@suse.de>
Cc: Olivier Berger <oberger@ouvaton.org>, linux-acpi@vger.kernel.org
Subject: Re: Incorrect ACPI blacklisting of ASUS P4B266 ?
Date: Thu, 14 May 2009 13:14:29 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.0905141307300.24833@localhost.localdomain> (raw)
In-Reply-To: <200904281956.50640.trenn@suse.de>

The P4B266 DMI entry went into ./arch/i386/kernel/dmi_scan.c
back in Aug-2003.

That was when I was just starting to maintain ACPI,
and I took a bunch of blacklist entries from SuSE
because they were already shipping with ACPI enabled.

In the short term, it may have been the right thing to do,
but in the long term it was a mistake and I regret doing it.

Blacklist entries paper-over real bugs, and unless we are lucky
enough that somebody like you, Oliver, steps forward,
blacklist entries are nearly impossible to ever remove.

So I'm inclined to apply your original patch to delete
the blacklist entry entirely.  If somebody with one of
those boxes has a regression, we'll go fix their box --
which we may have acutally fixed years ago and not known it...

thanks,
-Len

  parent reply	other threads:[~2009-05-14 17:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-28 15:32 Incorrect ACPI blacklisting of ASUS P4B266 ? Olivier Berger
     [not found] ` <200904021502.31021.trenn@suse.de>
2009-04-25 19:35   ` Olivier Berger
2009-04-27 10:18     ` Thomas Renninger
2009-04-28  6:09       ` Olivier Berger
2009-04-28 11:39         ` Thomas Renninger
2009-04-28 17:15           ` Olivier Berger
2009-04-28 17:56             ` Thomas Renninger
2009-04-30  4:22               ` Olivier Berger
2009-05-06  6:11                 ` Olivier Berger
2009-05-14 17:14               ` Len Brown [this message]
2009-05-17  7:38                 ` Olivier Berger
2009-05-22  5:52                   ` Olivier Berger
2009-05-14 17:18     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0905141307300.24833@localhost.localdomain \
    --to=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=oberger@ouvaton.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox