Linux ACPI
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	lenb@kernel.org, thisistempbox@yahoo.com, mingo@redhat.com
Subject: Re: [PATCH 1/2]cpuidle: makes AMD C1E works in acpi_idle
Date: Tue, 19 May 2009 14:55:10 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0905191447490.5983@localhost.localdomain> (raw)
In-Reply-To: <20090519080942.GA12117@sli10-desk.sh.intel.com>

On Tue, 19 May 2009, Shaohua Li wrote:

> When AMD C1E is enabled, local APIC timer will stop even in C1. This patch uses
> broadcast ipi to replace local APIC timer in C1.
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=13233

Hmm. This was addressed before in 

commit a8d6829044901a67732904be5f1eacdf8539604f (x86: prevent C-states
hang on AMD C1E enabled machines)

We limit C-States to 1 via acpi_processor_cstate_check().

And we have the broadcast logic in c1e_idle() already. We also select
c1e_idle as the idle routine, so why is the ACPI code not using this. ?

Thanks,

	tglx

  reply	other threads:[~2009-05-19 12:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-19  8:09 [PATCH 1/2]cpuidle: makes AMD C1E works in acpi_idle Shaohua Li
2009-05-19 12:55 ` Thomas Gleixner [this message]
2009-05-19 15:09   ` Shaohua Li
2009-05-19 15:24     ` Thomas Gleixner
2009-05-27  3:39 ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0905191447490.5983@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=shaohua.li@intel.com \
    --cc=thisistempbox@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox