Re: [PATCH]: ACPI: Change the array size from 5 to 8 for acpi_bus_id

[Len Brown <lenb@kernel.org>]

what bad things happen if this patch is not applied --
do some of those strcpy()'s overflow?

what good things happen if it is applied?

are you just eating up the padding because it is there?

thanks,
Len Brown, Intel Open Source Technology Center

On Thu, 21 May 2009, yakui_zhao wrote:

> From: Zhao Yakui <yaui.zhao@intel.com>
> 
> In fact the following three bytes can't be used when the following data
> type is unsigned long or unsigned long long.
> 
> Change the array size from 5 to 8 for the acpi_bus_id.
> 
> Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
> ---
>  include/acpi/acpi_bus.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/include/acpi/acpi_bus.h
> ===================================================================
> --- linux-2.6.orig/include/acpi/acpi_bus.h	2009-04-20 09:13:42.000000000 +0800
> +++ linux-2.6/include/acpi/acpi_bus.h	2009-05-21 16:18:25.000000000 +0800
> @@ -168,7 +168,7 @@
>  
>  /* Plug and Play */
>  
> -typedef char acpi_bus_id[5];
> +typedef char acpi_bus_id[8];
>  typedef unsigned long acpi_bus_address;
>  typedef char acpi_hardware_id[15];
>  typedef char acpi_unique_id[9];
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>