From: Len Brown <lenb@kernel.org>
To: yakui_zhao <yakui.zhao@intel.com>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [Resend] [PATCH]: ACPI: Rename ACPI processor device bus ID
Date: Fri, 05 Jun 2009 21:51:40 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0906052150040.5039@localhost.localdomain> (raw)
In-Reply-To: <1243737111.3634.168.camel@localhost.localdomain>
We've promised to delete /proc/acpi instead of enhance it,
so i'd rather see a patch that ignores errors from procfs
and registers the driver even when procfs fails.
thanks,
Len Brown, Intel Open Source Technology Center
On Sun, 31 May 2009, yakui_zhao wrote:
> From: Zhao Yakui <yakui.zhao@intel.com
>
> On some boxes several processors use the same processor bus id.
> But they are located in different scope. For example:
> \_SB.SCK0.CPU0
> \_SB.SCK1.CPU0
> As they use the same bus id, it can't be registered when
> registering proc I/F. It causes that the ACPI processor driver can't
> be bound with the processor device.
>
> Rename the processor device bus id. And the new bus id will be
> generated as the following format:
> CPU+ CPU ID
>
> For example: If the cpu ID is 5, then the bus ID will be "CPU5".
> If the CPU ID is 10, then the bus ID will be "CPUA".
>
> Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
> ---
> drivers/acpi/processor_core.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/acpi/processor_core.c
> ===================================================================
> --- linux-2.6.orig/drivers/acpi/processor_core.c 2009-05-27 08:38:44.000000000 +0800
> +++ linux-2.6/drivers/acpi/processor_core.c 2009-05-31 10:21:21.000000000 +0800
> @@ -649,7 +649,16 @@
> return -ENODEV;
> }
> }
> -
> + /*
> + * On some boxes several processors use the same processor bus id.
> + * But they are located in different scope. For example:
> + * \_SB.SCK0.CPU0
> + * \_SB.SCK1.CPU0
> + * Rename the processor device bus id. And the new bus id will be
> + * generated as the following format:
> + * CPU+CPU ID.
> + */
> + sprintf(acpi_device_bid(device), "CPU%X", pr->id);
> ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Processor [%d:%d]\n", pr->id,
> pr->acpi_id));
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2009-06-06 1:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 2:31 [Resend] [PATCH]: ACPI: Rename ACPI processor device bus ID yakui_zhao
2009-06-02 13:19 ` Thomas Renninger
2009-06-03 2:34 ` yakui_zhao
2009-06-03 9:14 ` Thomas Renninger
2009-06-06 1:51 ` Len Brown [this message]
2009-06-08 8:03 ` yakui_zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0906052150040.5039@localhost.localdomain \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox