From: Len Brown <lenb@kernel.org>
To: "Yu, Ke" <ke.yu@intel.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Tian, Kevin" <kevin.tian@intel.com>
Subject: RE: [Xen-devel] [PATCH][pvops_dom0][2/4] Introduce the external control operation interface for domain0 ACPI parser
Date: Thu, 30 Jul 2009 12:00:41 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0907301139530.17818@localhost.localdomain> (raw)
In-Reply-To: <4D05DB80B95B23498C72C700BD6C2E0B315D6A67@pdsmsx502.ccr.corp.intel.com>
> >My understanding is that all that code is supposed to be
> >kernel-independent. We could lift all that code as-is, write some new
> >kernel interface shims and shove it all into Xen. But I don't know if
> >that solves any more problems than it causes.
Many have incorporated ACPICA into their OS, from BeOS to BSD,
Solaris to Linux. And I'm not going to tell you that you can't
do the same and make the xen hypervisor into an OS that knows
about both policy and the hardware it is running on.
However, ACPI != all the ACPI code in Linux. ACPICA is the
stuff in the drivers/acpi/acpica directory, and nothing else
(asside from a few header files outside that directory)
Also, I'm not sure the OS you build will be competitive with
other OS's when you're done.
> >>> s/extcntl/xen/ to make it clear why this code exists --
> >>> or is there an expected "external control" other than Xen?
...
> >I don't think that's a good idea. If we need to do that, then there's a
> >deeper design problem we need to address. (And, if nothing else, people
> >have become hypersensitive to naked Xen-specific code references in
> >non-Xen files, and I'm tired of having those arguments.)
>
> Can you explain what the deeper design problem is?
Obfuscating the code by calling a Xen-specific abstraction
"extcntl" instead of "xen" will not fly.
Jeremy's desire to create and use generic abstractions that have multliple
users is a good thing. It simply does not apply here.
I have no objection to having a xen-specific hook being called xen_*
To do otherwise would be a dis-service to future maintainers of the code.
thanks,
Len Brown, Intel Open Source Technology Center.
next prev parent reply other threads:[~2009-07-30 16:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 2:55 FW: [Xen-devel] [PATCH][pvops_dom0][2/4] Introduce the external control operation interface for domain0 ACPI parser Yu, Ke
2009-07-29 4:14 ` Brown, Len
2009-07-29 6:20 ` Yu, Ke
2009-07-29 16:50 ` Jeremy Fitzhardinge
2009-07-30 9:18 ` Yu, Ke
2009-07-30 16:00 ` Len Brown [this message]
2009-07-30 20:36 ` Jeremy Fitzhardinge
2009-07-30 17:23 ` Jeremy Fitzhardinge
2009-07-30 15:37 ` Len Brown
2009-07-30 20:52 ` Jeremy Fitzhardinge
2009-07-29 14:47 ` Yu, Ke
2009-07-30 16:29 ` Len Brown
2009-07-30 22:04 ` Jeremy Fitzhardinge
2009-07-31 8:05 ` Yu, Ke
2009-07-29 16:43 ` Jeremy Fitzhardinge
2009-07-30 8:59 ` Yu, Ke
2009-07-30 15:03 ` Brown, Len
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0907301139530.17818@localhost.localdomain \
--to=lenb@kernel.org \
--cc=jeremy@goop.org \
--cc=ke.yu@intel.com \
--cc=kevin.tian@intel.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox