From: Len Brown <lenb@kernel.org>
To: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: Linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/3] ACPI: EC: use BURST mode only for MSI notebooks
Date: Sat, 29 Aug 2009 14:40:24 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0908291439320.23028@localhost.localdomain> (raw)
In-Reply-To: <20090828192944.19961.76281.stgit@thinkpad>
applied to ec branch in acpi-test for 2.6.32
The patch needs a check-in comment before it goes upstream, however.
thanks,
Len Brown, Intel Open Source Technology Center
On Fri, 28 Aug 2009, Alexey Starikovskiy wrote:
> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
> ---
>
> drivers/acpi/ec.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 78f8380..829e62e 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -627,7 +627,8 @@ acpi_ec_space_handler(u32 function, acpi_physical_address address,
> if (bits != 8 && acpi_strict)
> return AE_BAD_PARAMETER;
>
> - acpi_ec_burst_enable(ec);
> + if (EC_FLAGS_MSI)
> + acpi_ec_burst_enable(ec);
>
> if (function == ACPI_READ) {
> result = acpi_ec_read(ec, address, &temp);
> @@ -648,7 +649,8 @@ acpi_ec_space_handler(u32 function, acpi_physical_address address,
> }
> }
>
> - acpi_ec_burst_disable(ec);
> + if (EC_FLAGS_MSI)
> + acpi_ec_burst_disable(ec);
>
> switch (result) {
> case -EINVAL:
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2009-08-29 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 19:29 [PATCH 1/3] ACPICA: Don't switch task then not allowed Alexey Starikovskiy
2009-08-28 19:29 ` [PATCH 2/3] ACPI: EC: use BURST mode only for MSI notebooks Alexey Starikovskiy
2009-08-29 18:40 ` Len Brown [this message]
2009-08-28 19:29 ` [PATCH 3/3] ACPI: EC: Drop orphan comment Alexey Starikovskiy
2009-08-29 18:40 ` Len Brown
2009-08-29 18:41 ` [PATCH 1/3] ACPICA: Don't switch task then not allowed Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0908291439320.23028@localhost.localdomain \
--to=lenb@kernel.org \
--cc=Linux-acpi@vger.kernel.org \
--cc=astarikovskiy@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox