From: Len Brown <lenb@kernel.org>
To: Alan Jenkins <sourcejedi.lkml@googlemail.com>
Cc: Jean Delvare <jdelvare@suse.de>,
linux-acpi@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Thomas Renninger <trenn@suse.de>
Subject: Re: [PATCH] ACPI: Clarify resource conflict message
Date: Mon, 31 Aug 2009 13:19:38 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0908311305110.19451@localhost.localdomain> (raw)
In-Reply-To: <9b2b86520908301410i31b69f71s27809788d3b1f103@mail.gmail.com>
> > The message "ACPI: Device needs an ACPI driver" is misleading...
> > ACPI: Device may still be supported by an ACPI driver
> I would drop the word "still", but otherwise I think this is a good idea.
I agree we need to clarify this message.
Right now we have (copied from a recent bug report):
w83627ehf: Found W83627EHG chip at 0x290
ACPI: I/O resource w83627ehf [0x295-0x296] conflicts with ACPI region SEN1
[0x295-0x296]
ACPI: Device needs an ACPI driver
This results in people filing bugs against ACPI because their sensor
driver does not load -- we've seen several already.
I'm okay with the 1st ACPI line -- it tells somebody who cares exactly
what is going on.
"Device needs an ACPI driver", however, fails to tell the administrator
what they can do about it. We should probably mention that they
can test "acpi_enforce_resources=lax". However, we should probably
put a big WARNING - using-at-own-risk note in the dmesg when
that option is actually used.
And then what is the next course of action -- possible inclusion
on a white-list if they conflict turns out to be benign,
or (less likely) possible development of a missing ACPI driver?
We could have quite a few bug reports filed on this,
so wording is important.
thanks,
-Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2009-08-31 17:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-30 13:46 [PATCH] ACPI: Clarify resource conflict message Jean Delvare
2009-08-30 21:10 ` Alan Jenkins
2009-08-31 17:19 ` Len Brown [this message]
2009-09-07 13:36 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0908311305110.19451@localhost.localdomain \
--to=lenb@kernel.org \
--cc=jdelvare@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=sourcejedi.lkml@googlemail.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox