From mboxrd@z Thu Jan 1 00:00:00 1970 From: Len Brown Subject: Re: [PATCH 0/6] ACPI: dock: code hygiene Date: Fri, 09 Oct 2009 16:55:12 -0400 (EDT) Message-ID: References: <20091007220509.15597.65501.stgit@bob.kio> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from vms173009pub.verizon.net ([206.46.173.9]:13097 "EHLO vms173009pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934197AbZJIUzx (ORCPT ); Fri, 9 Oct 2009 16:55:53 -0400 In-reply-to: <20091007220509.15597.65501.stgit@bob.kio> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Alex Chiang Cc: linux-acpi@vger.kernel.org, Linux Kernel Mailing List , Shaohua Li series applied to acpi-test thanks, Len Brown, Intel Open Source Technology Center On Wed, 7 Oct 2009, Alex Chiang wrote: > While poking around in the dock driver debugging the NULL ptr that > Rafael fixed, I found the driver a little hard to read. > > Here is a modest attempt to clean it up a little, and is intended as > 2.6.33 material. > > Compile-tested only. I have access to an HP nc6220 and nc6230, but neither > of them seem to provide the _DCK method, which is needed for the dock > driver. > > Thanks. > > /ac > > --- > > Alex Chiang (6): > ACPI: dock: clean up error handling paths in dock_add() > ACPI: dock: rename local variable 'dock_station' in dock_add() > ACPI: dock: clean up one more error path in dock_add() > ACPI: dock: add struct dock_station * directly to platform device data > ACPI: dock: combine add|alloc_dock_dependent_device > ACPI: dock: minor whitespace and style cleanups > > > drivers/acpi/dock.c | 259 ++++++++++++++++++++------------------------------- > 1 files changed, 104 insertions(+), 155 deletions(-) >