[PATCH] asus-laptop: change light sens default values.

[PATCH] asus-laptop: change light sens default values.

[Corentin Chary]

The light sensor disable brightness key and
/sys/class/backlight/ control. There was a lot of report
from users who didn't understand why they couldn't change their
brightness, including:
* https://bugs.launchpad.net/bugs/222171
* https://bugzilla.novell.com/show_bug.cgi?id=514747
* http://bugzilla.kernel.org/show_bug.cgi?id=13671

Now the light sensor is disabled, and if the user want to enable
it, the level should be ok.

The funny thing is that comments where ok, not code.

Cc: stable@kernel.org
Cc: Thomas Renninger <trenn@suse.de>
Cc: Peter Küppers <peter-mailbox@web.de>
Cc: Michael Franzl <michaelfranzl@gmx.at>
Cc: Ian Turner <vectro@vectro.org>
Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
 drivers/platform/x86/asus-laptop.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index b39d2bb..849359a 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -1283,8 +1283,8 @@ static int asus_hotk_add(struct acpi_device *device)
 	hotk->ledd_status = 0xFFF;
 
 	/* Set initial values of light sensor and level */
-	hotk->light_switch = 1;	/* Default to light sensor disabled */
-	hotk->light_level = 0;	/* level 5 for sensor sensitivity */
+	hotk->light_switch = 0;	/* Default to light sensor disabled */
+	hotk->light_level = 5;	/* level 5 for sensor sensitivity */
 
 	if (ls_switch_handle)
 		set_light_sens_switch(hotk->light_switch);
-- 
1.6.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] asus-laptop: change light sens default values.

[Corentin Chary]

Hi Len,
please don't forget that one (it is easy to do so as it is not part of
the last series).
Thanks,

On Mon, Dec 7, 2009 at 10:05 PM, Corentin Chary <corentincj@iksaif.net> wrote:
> The light sensor disable brightness key and
> /sys/class/backlight/ control. There was a lot of report
> from users who didn't understand why they couldn't change their
> brightness, including:
> * https://bugs.launchpad.net/bugs/222171
> * https://bugzilla.novell.com/show_bug.cgi?id=514747
> * http://bugzilla.kernel.org/show_bug.cgi?id=13671
>
> Now the light sensor is disabled, and if the user want to enable
> it, the level should be ok.
>
> The funny thing is that comments where ok, not code.
>
> Cc: stable@kernel.org
> Cc: Thomas Renninger <trenn@suse.de>
> Cc: Peter Küppers <peter-mailbox@web.de>
> Cc: Michael Franzl <michaelfranzl@gmx.at>
> Cc: Ian Turner <vectro@vectro.org>
> Signed-off-by: Corentin Chary <corentincj@iksaif.net>
> ---
>  drivers/platform/x86/asus-laptop.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index b39d2bb..849359a 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -1283,8 +1283,8 @@ static int asus_hotk_add(struct acpi_device *device)
>        hotk->ledd_status = 0xFFF;
>
>        /* Set initial values of light sensor and level */
> -       hotk->light_switch = 1; /* Default to light sensor disabled */
> -       hotk->light_level = 0;  /* level 5 for sensor sensitivity */
> +       hotk->light_switch = 0; /* Default to light sensor disabled */
> +       hotk->light_level = 5;  /* level 5 for sensor sensitivity */
>
>        if (ls_switch_handle)
>                set_light_sens_switch(hotk->light_switch);
> --
> 1.6.5.4
>
>



-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] asus-laptop: change light sens default values.

[Len Brown]

applied

thanks,
Len Brown, Intel Open Source Technology Center