From: Len Brown <lenb@kernel.org>
To: "Youquan,Song" <youquan.song@linux.intel.com>
Cc: venkatesh.pallipadi@intel.com, kent.liu@intel.com,
chaohong.guo@intel.com, jane.lv@intel.com,
youquan.song@intel.com, linux-acpi@vger.kernel.org
Subject: Re: [PATCH]acpi cpuidle: Fix kernel oops when tickless is not enabled
Date: Wed, 16 Dec 2009 04:32:48 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.0912160431280.30935@localhost.localdomain> (raw)
In-Reply-To: <20091216141721.GA27614@youquan-linux.bj.intel.com>
Um, the purpose of the ladder governor is to handle the legacy tickfull
case, and this patch defeats that.
Can you share the actual failure?
thanks,
Len Brown, Intel Open Source Technology Center
On Wed, 16 Dec 2009, Youquan,Song wrote:
> Current kernel, if tickless is disabled,cpuidle governor ladder is built in,
> the kernel will boot oops on Boxboro-EX.
>
> After check in driver/cpuidle/Kconfig, menu governor built in kernel depends
> on tickless,but ladder governor has no such dependency.
>
> This patch add depnencey for ladder governor, so when tickless is disabled,
> ladder governor will not be built in.
>
> This is workround patch and the complete fix need be done at tickless.
>
> Signed-off-by: Youquan, Song <youquan.song@intel.com>
> ---
>
> diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig
> index 7dbc4a8..78d6d74 100644
> --- a/drivers/cpuidle/Kconfig
> +++ b/drivers/cpuidle/Kconfig
> @@ -11,7 +11,7 @@ config CPU_IDLE
>
> config CPU_IDLE_GOV_LADDER
> bool
> - depends on CPU_IDLE
> + depends on CPU_IDLE && NO_HZ
> default y
>
> config CPU_IDLE_GOV_MENU
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2009-12-16 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 14:17 [PATCH]acpi cpuidle: Fix kernel oops when tickless is not enabled Youquan,Song
2009-12-16 9:32 ` Len Brown [this message]
2009-12-17 11:27 ` Youquan,Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0912160431280.30935@localhost.localdomain \
--to=lenb@kernel.org \
--cc=chaohong.guo@intel.com \
--cc=jane.lv@intel.com \
--cc=kent.liu@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
--cc=youquan.song@intel.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox