From: Len Brown <lenb@kernel.org>
To: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Matthew Garrett <mjg@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux ACPI <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPI: WMI: Handle duplicate GUIDs
Date: Sat, 26 Dec 2009 14:42:02 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.0912261440290.4089@localhost.localdomain> (raw)
In-Reply-To: <200912261914.59515.carlos@strangeworlds.co.uk>
applied to acpi-test, after satisfying checkpatch's brace-foo below.
thanks,
Len Brown, Intel Open Source Technology Center
ERROR: open brace '{' following function declarations go on the next line
#34: FILE: drivers/platform/x86/wmi.c:719:
+static bool guid_already_parsed(const char *guid_string) {
WARNING: braces {} are not necessary for single statement blocks
#43: FILE: drivers/platform/x86/wmi.c:728:
+ if (strncmp(gblock->guid, guid_string, 16) == 0) {
+ return true;
+ }
total: 1 errors, 1 warnings, 48 lines checked
next prev parent reply other threads:[~2009-12-26 19:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-25 20:48 Regression in module wmi since 2.6.32 (bisected to commit 1caab3c) Larry Finger
2009-12-25 20:56 ` Carlos Corbacho
2009-12-25 21:35 ` Larry Finger
2009-12-25 21:58 ` Carlos Corbacho
2009-12-25 22:09 ` Larry Finger
2009-12-26 1:18 ` Carlos Corbacho
2009-12-26 1:36 ` Dmitry Torokhov
2009-12-26 15:32 ` Larry Finger
2009-12-26 18:36 ` Carlos Corbacho
2009-12-26 19:04 ` Larry Finger
2009-12-26 19:14 ` [PATCH] ACPI: WMI: Handle duplicate GUIDs Carlos Corbacho
2009-12-26 19:42 ` Len Brown [this message]
2010-01-06 15:27 ` Regression in module wmi since 2.6.32 (bisected to commit 1caab3c) Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0912261440290.4089@localhost.localdomain \
--to=lenb@kernel.org \
--cc=Larry.Finger@lwfinger.net \
--cc=carlos@strangeworlds.co.uk \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox