public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Zhang Rui <rui.zhang@intel.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPI: introduce kernel parameter acpi_sleep=s3_set_sci_en
Date: Wed, 30 Dec 2009 02:04:23 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0912300202060.15839@localhost.localdomain> (raw)
In-Reply-To: <200910281952.27856.rjw@sisk.pl>

> > > > Introduce kernel parameter acpi_sleep=s3_set_sci_en
> > > > 
> > > > some laptop requires SCI_EN being set directly on resume,
> > > > or else they hung somewhere in the resume code path.
> > > > 
> > > > We already have a blacklist for these lattops but we still need
> > > > this option, especially when debugging some suspend/resume problems,
> > > > in case there are systems that need this workaround and are not yet
> > > > in the blacklist.
> > > > 
> > > > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
...
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> 
> This one looks better.
> 
> OK, Len, are you going to apply it or do you want me to handle it?


As this isn't actually S3 specific, lets give this a better name, say

acpi_sleep=sci_force_enable

what you think?

thanks,
-Len Brown, Intel Open Source Technology Center



      reply	other threads:[~2009-12-30  7:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-27  2:23 [PATCH] ACPI: introduce kernel parameter acpi_sleep=s3_set_sci_en Zhang Rui
2009-10-27  8:21 ` Rafael J. Wysocki
2009-10-27  8:46   ` Zhang Rui
2009-10-27 10:15     ` Rafael J. Wysocki
2009-10-28  1:36   ` Zhang Rui
2009-10-28 18:52     ` Rafael J. Wysocki
2009-12-30  7:04       ` Len Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0912300202060.15839@localhost.localdomain \
    --to=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox