From: Len Brown <lenb@kernel.org>
To: linux-acpi@vger.kernel.org
Cc: Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH 07/10] ACPI: fix "acpi=ht" boot option (take two, don't break ia64 build)
Date: Thu, 18 Feb 2010 04:00:08 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1002180355150.4135@localhost.localdomain> (raw)
In-Reply-To: <f543ebdcbca887886417793ded9e8b71b4436e55.1266313501.git.len.brown@intel.com>
From: Len Brown <len.brown@intel.com>
We broke "acpi=ht" in 2.6.32 by disabling MADT parsing
for acpi=disabled. e5b8fc6ac158f65598f58dba2c0d52ba3b412f52
This also broke systems which invoked acpi=ht via DMI blacklist.
acpi=ht is a really ugly hack,
but restore it for those that still use it.
http://bugzilla.kernel.org/show_bug.cgi?id=14886
Signed-off-by: Len Brown <len.brown@intel.com>
---
arch/ia64/include/asm/acpi.h | 1 +
drivers/acpi/tables.c | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/ia64/include/asm/acpi.h b/arch/ia64/include/asm/acpi.h
index 7ae5889..e97b255 100644
--- a/arch/ia64/include/asm/acpi.h
+++ b/arch/ia64/include/asm/acpi.h
@@ -94,6 +94,7 @@ ia64_acpi_release_global_lock (unsigned int *lock)
#define acpi_noirq 0 /* ACPI always enabled on IA64 */
#define acpi_pci_disabled 0 /* ACPI PCI always enabled on IA64 */
#define acpi_strict 1 /* no ACPI spec workarounds on IA64 */
+#define acpi_ht 0 /* no HT-only mode on IA64 */
#endif
#define acpi_processor_cstate_check(x) (x) /* no idle limits on IA64 :) */
static inline void disable_acpi(void) { }
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index f336bca..8a0ed28 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -213,7 +213,7 @@ acpi_table_parse_entries(char *id,
unsigned long table_end;
acpi_size tbl_size;
- if (acpi_disabled)
+ if (acpi_disabled && !acpi_ht)
return -ENODEV;
if (!handler)
@@ -280,7 +280,7 @@ int __init acpi_table_parse(char *id, acpi_table_handler handler)
struct acpi_table_header *table = NULL;
acpi_size tbl_size;
- if (acpi_disabled)
+ if (acpi_disabled && !acpi_ht)
return -ENODEV;
if (!handler)
--
1.7.0.17.g7e5eb
next prev parent reply other threads:[~2010-02-18 9:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 9:46 ACPI paches for 2.6.33-rc8 Len Brown
2010-02-16 9:46 ` [PATCH 01/10] ACPI: processor: add kernel command line support for early _PDC eval Len Brown
2010-02-16 9:46 ` [PATCH 02/10] ACPI: processor: only evaluate _PDC once per processor Len Brown
2010-02-16 9:46 ` [PATCH 03/10] ACPI: Add NULL pointer check in acpi_bus_start Len Brown
2010-02-16 9:46 ` [PATCH 04/10] ACPI: acpi_bus_{scan,bus,add}: return -ENODEV if no device was found Len Brown
2010-02-16 9:46 ` [PATCH 05/10] thinkpad-acpi: wrong thermal attribute_group removed in thermal_exit() Len Brown
2010-02-16 9:46 ` [PATCH 06/10] ACPI: remove Asus P2B-DS from acpi=ht blacklist Len Brown
2010-02-16 9:46 ` [PATCH 07/10] ACPI: fix "acpi=ht" boot option Len Brown
2010-02-18 9:00 ` Len Brown [this message]
2010-02-16 9:46 ` [PATCH 08/10] ACPI: dock: properly initialize local struct dock_station in dock_add() Len Brown
2010-02-16 9:46 ` [PATCH 09/10] ACPI: fix High cpu temperature with 2.6.32 Len Brown
2010-02-16 9:46 ` [PATCH 10/10] ACPI, i915: blacklist Clevo M5x0N bad_lid state Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1002180355150.4135@localhost.localdomain \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox