Re: [PATCH] trival: fix acpi_hest_firmware_first_pci() caused oops

[Len Brown <lenb@kernel.org>]

wouldn't it be better for acpi_get_table()
to return failure for acpi=off?

thanks,
Len Brown, Intel Open Source Technology Center

On Thu, 8 Apr 2010, Shaohua Li wrote:

> acpi_hest_firmware_first_pci() could be called when acpi is disabled
> and cause system oops.
> 
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> ---
>  drivers/acpi/hest.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/acpi/hest.c b/drivers/acpi/hest.c
> index 4bb18c9..1c527a1 100644
> --- a/drivers/acpi/hest.c
> +++ b/drivers/acpi/hest.c
> @@ -123,6 +123,10 @@ int acpi_hest_firmware_first_pci(struct pci_dev *pci)
>  {
>  	acpi_status status = AE_NOT_FOUND;
>  	struct acpi_table_header *hest = NULL;
> +
> +	if (acpi_disabled)
> +		return 0;
> +
>  	status = acpi_get_table(ACPI_SIG_HEST, 1, &hest);
>  
>  	if (ACPI_SUCCESS(status)) {
> -- 
> 1.6.3.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>