public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org,
	Pavel Kysilka <goldenfish@linuxsoft.cz>,
	Adam Belay <abelay@mit.edu>, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH] PNP: don't check for conflicts with bridge windows
Date: Mon, 3 May 2010 16:03:11 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.1005031601450.5478@i5.linux-foundation.org> (raw)
In-Reply-To: <1272927008.28149.91.camel@dc7800.home>



On Mon, 3 May 2010, Bjorn Helgaas wrote:
> 
> My *plan* was to make pci_root.c a PNP driver, so it would use the
> pre-parsed PNP resources to find the host bridge windows rather than
> re-parsing the ACPI _CRS info by hand.  Those PNP resources are not in
> the resource tree when the driver first sees them (which might be a
> deficiency of our current PNP core), so I don't think there's currently
> a way for the driver to distinguish IO from MEM unless it's in the
> resource itself.
> 
> At this stage of the release, my preference would be to use the patch
> above (with the intention of coming back later for some more work), or
> to just revert fa35b4926 (PNPACPI window support) and maybe 9d7cca04
> (generic window support).  If we revert those patches, I'll have to
> figure out another way to clean up pci_root.c.

Oh, I'm fine with your patch, I just reacted to it wondering whether maybe 
there was some cleaner way of solving the problem. I guess annotating the 
resource itself is ok.

So don't take my comment as a NAK, more of a "hmm, how about.. "

		Linus

  reply	other threads:[~2010-05-03 23:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-03 16:47 [PATCH] PNP: don't check for conflicts with bridge windows Bjorn Helgaas
2010-05-03 16:47 ` Bjorn Helgaas
2010-05-03 16:53   ` Linus Torvalds
2010-05-03 22:50     ` Bjorn Helgaas
2010-05-03 23:03       ` Linus Torvalds [this message]
2010-05-06  6:09   ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1005031601450.5478@i5.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=abelay@mit.edu \
    --cc=bjorn.helgaas@hp.com \
    --cc=goldenfish@linuxsoft.cz \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox