From: Len Brown <lenb@kernel.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] trival: fix acpi_hest_firmware_first_pci() caused oops
Date: Thu, 06 May 2010 02:33:08 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1005060221270.28850@localhost.localdomain> (raw)
In-Reply-To: <20100505013923.GA30454@sli10-desk.sh.intel.com>
> > wouldn't it be better for acpi_get_table()
> > to return failure for acpi=off?
> but acpi_disabled is a linux variable while acpi_get_table is ACPICA code.
For the acpi_disabled case, acpi_get_table() will return AE_NOT_FOUND
because acpi_gbl_root_table_list.count == 0,
and leave the table pointer unchanged at NULL, yes?
Looking at the other callers of acpi_get_table(),
they all seem to be called when acpi is enabled
and they know the table in question is going to be there.
So I guess it is consistent for hest.c to know this too.
But it looks like acpi_get_table() should fail gracefully,
so why do we take a fault?
-Len
prev parent reply other threads:[~2010-05-06 6:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 3:16 [PATCH] trival: fix acpi_hest_firmware_first_pci() caused oops Shaohua Li
2010-04-20 15:01 ` Len Brown
2010-05-05 1:39 ` Shaohua Li
2010-05-06 6:33 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1005060221270.28850@localhost.localdomain \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox