From: Linus Torvalds <torvalds@linux-foundation.org>
To: Len Brown <lenb@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [git pull request] ACPI patches for 2.6.34-rc6
Date: Thu, 6 May 2010 19:34:10 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1005061926460.901@i5.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1005062216430.10792@localhost.localdomain>
On Thu, 6 May 2010, Len Brown wrote:
>
> The big DMI list in sleep.c a temporary brute force and low-risk workaround.
> We will endeavor to delete it entirely in 2.6.35 with a clean fix
> that was deemed too risky for this late in the .34 release cycle.
Btw, why don't we just force the SCI_EN by hand?
We did that for the Apple Mac Mini bug too. It was always the right thing
to do.
There is _no_ reason not to force it. If the BIOS set it, it's a no-op. If
the BIOS didn't set it, it's a bug that _must_ be fixed.
I really don't see the reason for that DMI list. What could _possibly_ go
wrong for just setting the damn bit that we _know_ has to be set?
How could setting SCI_EN _ever_ be a bug? Seriously? Why are we doing this
conditionally, especially considering that even the commit message here
explicitly states that Windows does it unconditionally?
And no, I'm not interested in "that toilet paper spec says you can't touch
it". I care about _reality_.
Linus
next prev parent reply other threads:[~2010-05-07 2:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 2:22 [git pull request] ACPI patches for 2.6.34-rc6 Len Brown
2010-05-07 2:34 ` Linus Torvalds [this message]
2010-05-07 6:12 ` Matthew Garrett
2010-05-07 21:06 ` Linus Torvalds
2010-05-07 21:13 ` Matthew Garrett
2010-05-07 21:21 ` Linus Torvalds
2010-05-07 21:36 ` Matthew Garrett
2010-05-11 17:25 ` Matthew Garrett
2010-05-11 17:42 ` Linus Torvalds
2010-05-11 17:59 ` Matthew Garrett
2010-05-11 18:17 ` Linus Torvalds
2010-05-11 18:22 ` Matthew Garrett
2010-05-12 16:07 ` Robert Wörle
2010-05-12 16:12 ` Matthew Garrett
2010-05-07 22:39 ` Rafael J. Wysocki
2010-05-07 23:00 ` Linus Torvalds
2010-05-07 23:17 ` Rafael J. Wysocki
2010-05-07 23:21 ` Linus Torvalds
2010-05-08 0:03 ` Rafael J. Wysocki
2010-05-08 0:10 ` Linus Torvalds
2010-05-08 5:19 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1005061926460.901@i5.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox