From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [git pull request] ACPI patches for 2.6.34-rc6 Date: Fri, 7 May 2010 16:21:13 -0700 (PDT) Message-ID: References: <201005080039.45533.rjw@sisk.pl> <201005080117.23760.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:35088 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951Ab0EGXXO (ORCPT ); Fri, 7 May 2010 19:23:14 -0400 In-Reply-To: <201005080117.23760.rjw@sisk.pl> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Len Brown , Linux Kernel Mailing List , linux-acpi@vger.kernel.org, Andrew Morton On Sat, 8 May 2010, Rafael J. Wysocki wrote: > On Saturday 08 May 2010, Linus Torvalds wrote: > > > > On Sat, 8 May 2010, Rafael J. Wysocki wrote: > > > > > On Friday 07 May 2010, Linus Torvalds wrote: > > > > > > > > Btw, why don't we just force the SCI_EN by hand? > > > > > > Because there are boxes that are broken right away by this. > > > > > > I have one on my desk in front of me. :-) > > > > Also if we check whether it was already set before? > > Yes. I don't think you understood the question. If we check whether it was already set before, we wouldn't _do_ it by hand. > > The thing is, if that bit is clear (_after_ we've done the regular ACPI > > setup), the box can't work correctly as far as I know. > > That's correct. But on that particular box acpi_enable() is necessary to > make things work. Setting SCI_EN by hand makes it hang solid. Let me explain what I think we should do with actual code: acpi_enable(); if (test_if_that_f_cking_bit_still_isnt_set) set_it_by_hand(); wouldn't that work on your box? The acpi_enable() seems to work for you, so it wouldn't actually ever set it by hand. But the problem is that on a number of boxes, acpi_enable() apparently doesn't do what it should do. Because the stupid BIOS "knows" it is already in ACPI mode, but it forgot to actually set the bit! Linus