From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [git pull request] ACPI patches for 2.6.34-rc6 Date: Tue, 11 May 2010 11:17:34 -0700 (PDT) Message-ID: References: <20100507061203.GA8779@srcf.ucam.org> <20100507211331.GA28906@srcf.ucam.org> <20100507213600.GC28906@srcf.ucam.org> <20100511172543.GA17868@srcf.ucam.org> <20100511175904.GA18797@srcf.ucam.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <20100511175904.GA18797@srcf.ucam.org> Sender: linux-kernel-owner@vger.kernel.org To: Matthew Garrett Cc: Len Brown , Linux Kernel Mailing List , linux-acpi@vger.kernel.org, Andrew Morton List-Id: linux-acpi@vger.kernel.org On Tue, 11 May 2010, Matthew Garrett wrote: > > I see Windows write the SCI_EN bit without reading it first and without > calling the ACPI enable SMM function. Hmm. So presumably Windows doesn't even do them bit-by-bit, but simply does a "restore PM1 Control register value" on resume. And I guess it probably does the same for the PM1_ENABLE register and the PM2 control registers too? Just restoring the whole register values _does_ sound a lot simpler than worrying about individual bits. Linus