* [PATCH 11/37] drivers/acpi: Use kmemdup
@ 2010-05-15 21:16 Julia Lawall
2010-05-15 21:33 ` Alexey Starikovskiy
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2010-05-15 21:16 UTC (permalink / raw)
To: Alexey Starikovskiy, Len Brown, linux-acpi, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
Use kmemdup when some other buffer is immediately copied into the
allocated region.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression from,to,size,flag;
statement S;
@@
- to = \(kmalloc\|kzalloc\)(size,flag);
+ to = kmemdup(from,size,flag);
if (to==NULL || ...) S
- memcpy(to, from, size);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/acpi/ec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -u -p a/drivers/acpi/ec.c b/drivers/acpi/ec.c
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -1027,10 +1027,9 @@ int __init acpi_ec_ecdt_probe(void)
/* Don't trust ECDT, which comes from ASUSTek */
if (!EC_FLAGS_VALIDATE_ECDT)
goto install;
- saved_ec = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
+ saved_ec = kmemdup(boot_ec, sizeof(struct acpi_ec), GFP_KERNEL);
if (!saved_ec)
return -ENOMEM;
- memcpy(saved_ec, boot_ec, sizeof(struct acpi_ec));
/* fall through */
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 11/37] drivers/acpi: Use kmemdup
2010-05-15 21:16 [PATCH 11/37] drivers/acpi: Use kmemdup Julia Lawall
@ 2010-05-15 21:33 ` Alexey Starikovskiy
2010-05-20 5:03 ` Len Brown
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Starikovskiy @ 2010-05-15 21:33 UTC (permalink / raw)
To: Julia Lawall; +Cc: Len Brown, linux-acpi, linux-kernel, kernel-janitors
Hi Julia,
Acked-by: Alexey Starikovskiy <astarikovskiy@suse.de>
Thanks,
Alex.
16.05.2010 01:16, Julia Lawall пишет:
> From: Julia Lawall<julia@diku.dk>
>
> Use kmemdup when some other buffer is immediately copied into the
> allocated region.
>
> A simplified version of the semantic patch that makes this change is as
> follows: (http://coccinelle.lip6.fr/)
>
> //<smpl>
> @@
> expression from,to,size,flag;
> statement S;
> @@
>
> - to = \(kmalloc\|kzalloc\)(size,flag);
> + to = kmemdup(from,size,flag);
> if (to==NULL || ...) S
> - memcpy(to, from, size);
> //</smpl>
>
> Signed-off-by: Julia Lawall<julia@diku.dk>
>
> ---
> drivers/acpi/ec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -u -p a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -1027,10 +1027,9 @@ int __init acpi_ec_ecdt_probe(void)
> /* Don't trust ECDT, which comes from ASUSTek */
> if (!EC_FLAGS_VALIDATE_ECDT)
> goto install;
> - saved_ec = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
> + saved_ec = kmemdup(boot_ec, sizeof(struct acpi_ec), GFP_KERNEL);
> if (!saved_ec)
> return -ENOMEM;
> - memcpy(saved_ec, boot_ec, sizeof(struct acpi_ec));
> /* fall through */
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-20 5:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-15 21:16 [PATCH 11/37] drivers/acpi: Use kmemdup Julia Lawall
2010-05-15 21:33 ` Alexey Starikovskiy
2010-05-20 5:03 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).