From: Len Brown <lenb@kernel.org>
To: Jerone Young <jerone.young@canonical.com>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] [RESUBMIT] Fix mute key on older Lenovo made Thinkpads by OSI blacklisting
Date: Thu, 20 May 2010 01:48:17 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1005200136220.2921@localhost.localdomain> (raw)
In-Reply-To: <1274329374.4479.403.camel@laptop>
thanks for the DSDT for the x200 and x301.
In these two cases, the OSI(Linux) workaround looks isolated,
and thus relatively safe.
I've applied your patch to the ACPI test branch, and I'm inclined to
push it with 2.6.35 with the justification that it is consistent
with our current DMI entries to fix thinkpad mute button on other
models.
Matthew, Henrique,
If you'd like to talk me out of this, now is your chance:-)
thanks,
Len Brown, Intel Open Source Technology Center
Both the x200 and x301 DSDT do this:
If (CondRefOf (\_OSI, Local0))
{
If (\_OSI ("Windows 2001"))
{
Store (0x01, \WNTF)
Store (0x01, \WXPF)
Store (0x00, \WSPV)
}
If (\_OSI ("Windows 2001 SP1"))
{
Store (0x01, \WSPV)
}
If (\_OSI ("Windows 2001 SP2"))
{
Store (0x02, \WSPV)
}
If (\_OSI ("Windows 2006"))
{
Store (0x01, \WVIS)
}
If (\_OSI ("Windows 2009"))
{
Store (0x01, \WIN7)
}
If (\_OSI ("Linux"))
{
Store (0x01, \LNUX)
}
The important thing here is that OSI(Linux)
doesn't disable any of the windows compatibility
flags above as it does in some other DSDTs.
If (\_OSI ("FreeBSD"))
{
Store (0x01, \LNUX)
}
and this _INI-time check is the only effect of LNUX:
If (\LNUX)
{
\_SB.PCI0.LPC.EC.SAUM (0x02)
\UCMS (0x1C)
}
Of course SAUM pokes the EC and UCMS is an SMI wrapper,
so we don't really know all they may do; but at least
OSI(Linux) doesn't obviously disable the concept of
windows compatibility in this BIOS, and checks for
LNUX are limited to init-time.
next prev parent reply other threads:[~2010-05-20 5:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-02 3:20 [PATCH] [RESUBMIT] Fix mute key on older Lenovo made Thinkpads by OSI blacklisting Jerone Young
2010-05-20 3:34 ` Len Brown
[not found] ` <1274329374.4479.403.camel@laptop>
2010-05-20 5:48 ` Len Brown [this message]
2010-05-20 19:14 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1005200136220.2921@localhost.localdomain \
--to=lenb@kernel.org \
--cc=jerone.young@canonical.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox