From: Len Brown <lenb@kernel.org>
To: Venkatesh Pallipadi <venki@google.com>
Cc: ACPI list <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] acpi: Eliminate us to pm ticks conversion in common path
Date: Fri, 04 Jun 2010 03:44:29 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1006040343380.6669@localhost.localdomain> (raw)
In-Reply-To: <1275498069-30614-1-git-send-email-venki@google.com>
> Is this one better?
Yes, but the patch I'm really looking forward to
removed /proc/acpi/processor/*/power altogether...
applied,
thanks,
-Len Brown, Intel Open Source Technology Center
>
> acpi_enter_[simple|bm] routines does us to pm tick conversion on every
> idle wakeup and the value is only used in /proc/acpi display. We can
> store the time in us and convert it into pm ticks before printing instead and
> avoid the conversion in the common path.
>
> Signed-off-by: Venkatesh Pallipadi <venki@google.com>
> ---
> drivers/acpi/processor_idle.c | 15 +++++----------
> 1 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index 2e8c27d..71c9608 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -80,7 +80,7 @@ module_param(nocst, uint, 0000);
> static unsigned int latency_factor __read_mostly = 2;
> module_param(latency_factor, uint, 0644);
>
> -static s64 us_to_pm_timer_ticks(s64 t)
> +static u64 us_to_pm_timer_ticks(s64 t)
> {
> return div64_u64(t * PM_TIMER_FREQUENCY, 1000000);
> }
> @@ -731,10 +731,10 @@ static int acpi_processor_power_seq_show(struct seq_file *seq, void *offset)
>
> seq_puts(seq, "demotion[--] ");
>
> - seq_printf(seq, "latency[%03d] usage[%08d] duration[%020llu]\n",
> + seq_printf(seq, "latency[%03d] usage[%08d] duration[%020Lu]\n",
> pr->power.states[i].latency,
> pr->power.states[i].usage,
> - (unsigned long long)pr->power.states[i].time);
> + us_to_pm_timer_ticks(pr->power.states[i].time));
> }
>
> end:
> @@ -861,7 +861,6 @@ static int acpi_idle_enter_simple(struct cpuidle_device *dev,
> ktime_t kt1, kt2;
> s64 idle_time_ns;
> s64 idle_time;
> - s64 sleep_ticks = 0;
>
> pr = __get_cpu_var(processors);
>
> @@ -906,8 +905,6 @@ static int acpi_idle_enter_simple(struct cpuidle_device *dev,
> idle_time = idle_time_ns;
> do_div(idle_time, NSEC_PER_USEC);
>
> - sleep_ticks = us_to_pm_timer_ticks(idle_time);
> -
> /* Tell the scheduler how much we idled: */
> sched_clock_idle_wakeup_event(idle_time_ns);
>
> @@ -918,7 +915,7 @@ static int acpi_idle_enter_simple(struct cpuidle_device *dev,
> cx->usage++;
>
> lapic_timer_state_broadcast(pr, cx, 0);
> - cx->time += sleep_ticks;
> + cx->time += idle_time;
> return idle_time;
> }
>
> @@ -940,7 +937,6 @@ static int acpi_idle_enter_bm(struct cpuidle_device *dev,
> ktime_t kt1, kt2;
> s64 idle_time_ns;
> s64 idle_time;
> - s64 sleep_ticks = 0;
>
>
> pr = __get_cpu_var(processors);
> @@ -1026,7 +1022,6 @@ static int acpi_idle_enter_bm(struct cpuidle_device *dev,
> idle_time = idle_time_ns;
> do_div(idle_time, NSEC_PER_USEC);
>
> - sleep_ticks = us_to_pm_timer_ticks(idle_time);
> /* Tell the scheduler how much we idled: */
> sched_clock_idle_wakeup_event(idle_time_ns);
>
> @@ -1037,7 +1032,7 @@ static int acpi_idle_enter_bm(struct cpuidle_device *dev,
> cx->usage++;
>
> lapic_timer_state_broadcast(pr, cx, 0);
> - cx->time += sleep_ticks;
> + cx->time += idle_time;
> return idle_time;
> }
>
> --
> 1.7.0.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-06-04 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 23:48 [PATCH] acpi: Minor cleanup eliminating redundant PMTIMER_TICKS to NS conversion Venkatesh Pallipadi
2010-05-18 1:47 ` Venkatesh Pallipadi
2010-05-28 19:09 ` Len Brown
2010-06-02 17:01 ` [PATCH] acpi: Eliminate us to pm ticks conversion in common path Venkatesh Pallipadi
2010-06-04 7:44 ` Len Brown [this message]
2010-05-28 19:10 ` [PATCH] acpi: Minor cleanup eliminating redundant PMTIMER_TICKS to NS conversion Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1006040343380.6669@localhost.localdomain \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox