Re: [PATCH 1/2] suspend: Move NVS save/restore code to generic suspend functionality

Maxim Levitsky
2010-06-10T15:21:14Z

On Thu, 2010-06-10 at 11:11 -0400, Len Brown wrote:
> On Sat, 5 Jun 2010, Maxim Levitsky wrote:
>
> > On Fri, 2010-06-04 at 15:11 -0400, Len Brown wrote:
> > > > Since the other patch 'ACPI / EC / PM: Fix race between EC transactions
> > > > and system suspend' is now merged, this should be rebased on top of it
> > > > (I did the opposite....)
> > >
> > > Maxim,
> > > Since your system needs both these fixes, and they are merged together
> > > in the acpi git tree, it would be great if you could test that tree
> > > and let me know if we got it right.
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git test
>
>
> > Which kernel do you expect these patches to land on?
>
> the test tree above is in linux-next now.
> there are some patches that will be 2.6.36 in there,
> but I was considereing this one for 2.6.35-rc3 --
> though your e-mail with a stack trace has caused me to pause --
> did I mis-merge it?

I can't reproduce that anymore.
I had a userspace script that would mmap /dev/mem and 'fix' the issue.
I used it to help some ubuntu users and to test some unrelated work on
ubuntu kernel.

Yet, the script should exit before write to /sys/power/state.

However when this happened I also closed the system's lid, which might
make the same script to run in parallel, and therefore an attempt to
ioremap the NVS area failed.
can't think for any other explanation why ioremap could fail.
Anyway, I think it would be safe to add a check to and abort suspend if
ioremap fails.

I don't use this script anymore.

Best regards,
Maxim Levitsky