From: Len Brown <lenb@kernel.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 1/5] ACPI: remove ACPI debugfs out of drivers/acpi/debug.c
Date: Fri, 11 Jun 2010 11:53:12 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1006111143020.4096@localhost.localdomain> (raw)
In-Reply-To: <1276235272.19052.15871.camel@rzhang1-desktop>
On Fri, 11 Jun 2010, Zhang Rui wrote:
> ACPI debugfs I/F should not depend on CONFIG_ACPI_DEBUG.
It would be good to state how much size you are adding to ACPI here --
since it will be an additional size burnden to those not already
shipping with CONFIG_ACPI_DEBUG=y.
> Introduce driver/acpi/debugfs.c for ACPI debugfs I/F.
>
> No function change in this patch.
>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
> drivers/acpi/Makefile | 1
> drivers/acpi/bus.c | 1
> drivers/acpi/debug.c | 75 ---------------------------------------------
> drivers/acpi/debugfs.c | 80 ++++++++++++++++++++++++++++++++++++++++++++++++
> drivers/acpi/internal.h | 1
> 5 files changed, 83 insertions(+), 75 deletions(-)
>
> Index: linux-2.6/drivers/acpi/debugfs.c
> ===================================================================
> +++ linux-2.6/drivers/acpi/Makefile
> @@ -38,6 +38,7 @@ acpi-$(CONFIG_ACPI_DOCK) += dock.o
> acpi-y += pci_root.o pci_link.o pci_irq.o pci_bind.o
> acpi-y += power.o
> acpi-y += system.o event.o
> +acpi-y += debugfs.o
> acpi-$(CONFIG_ACPI_DEBUG) += debug.o
Perhaps it would make sense for this file to depend on CONFIG_DEBUG_FS
and have it cost 0-bytes when not set -- along with a static inline
for acpi_debugfs_init()?
Though honestly, with CONFIG_TRACING and others selecting it,
DEBUG_FS is probably enabled on most systems...
thanks,
-Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-06-11 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 5:47 [PATCH 1/5] ACPI: remove ACPI debugfs out of drivers/acpi/debug.c Zhang Rui
2010-06-11 15:53 ` Len Brown [this message]
2010-06-12 2:57 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1006111143020.4096@localhost.localdomain \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox