Linux ACPI
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 0/5] ACPI: procfs/sysfs/debugfs code cleanup
Date: Fri, 11 Jun 2010 12:48:32 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.1006111211450.4096@localhost.localdomain> (raw)
In-Reply-To: <1276235269.19052.15870.camel@rzhang1-desktop>

On Fri, 11 Jun 2010, Zhang Rui wrote:

> This patch set mainly cleans up the ACPI procfs/sysfs/debugfs code.
> 
> 1. removes the deprecated ACPI procfs I/F, including
>    /proc/acpi/debug_layer
>    /proc/acpi/debug_level
>    /proc/acpi/info
>    /proc/acpi/dsdt
>    /proc/acpi/fadt
>    because the sysfs I/F have been working for years without any problems.

Documentation/feature-removal-schedule.txt has warned
that we'd delete all of /proc/acpi/ for a long time now,
but we seem to have somewhat stalled out on that quest.

After this patch series, it seems like a good time to take inventory
of /proc/acpi/, list every file, and list if and when it will go away..
A section in feature-removal-schedule.txt is probably as good a place
as any for this.

Files that are deprecated should all be put under CONFIG_ACPI_PROCFS
where they should wait to be deleted for at least one release.

(Also, this patch series needs to update drivers/acpi/Kconfig comments
 because it removes some files that were aging under CONFIG_ACPI_PROCFS)

/proc/acpi/event was deemed too special to age under
CONFIG_ACPI_PROCFS, and so it has its own CONFIG_ACPI_PROC_EVENT
I think losing its default =y now would make sense,
and move it under CONFIG_ACPI_PROCFS in a year?
and hopefully delete it entirely in another year?

CONFIG_PROCFS_POWER should proably now also lose its default =y.
If current user-space no longer needs this, then
in a few releases it can get sucked under CONFIG_ACPI_PROCFS.

About 50% of button.c is suport for /proc/acpi/button/* --
it will be satisfying to simplify that one.
We tried to delete that code once, but somebody reads
the lid status, and so we restored it.
I don't know if we can get the LID status from anyplace else,
so that file may have to remain longer, but the other
/proc/acpi/button files are useuless and can go in 1 release.

thanks,
Len Brown, Intel Open Source Technology Center


  reply	other threads:[~2010-06-11 16:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-11  5:47 [PATCH 0/5] ACPI: procfs/sysfs/debugfs code cleanup Zhang Rui
2010-06-11 16:48 ` Len Brown [this message]
2010-06-12  3:18   ` Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1006111211450.4096@localhost.localdomain \
    --to=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox