Re: [PATCH 1/4] ACPI AC/Battery/SBS: deprecate procfs I/F and make sysfs I/F always built in

[Len Brown <lenb@kernel.org>]

On Sat, 2 Oct 2010, Zhang Rui wrote:

> 
> ACPI AC/Battery/SBS driver has different kernel option for procfs and sysfs I/F.
> 
> This patch,
> 1. Change CONFIG_ACPI_PROCFS_POWER to 'n' by default so that we can remove it in the next release or two.
> 2. Remove CONFIG_ACPI_SYSFS_POWER and always build in the sysfs I/F of these drivers.
> 
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
>  drivers/acpi/Kconfig   |    9 +--------
>  drivers/acpi/ac.c      |   14 --------------
>  drivers/acpi/battery.c |   21 ---------------------
>  drivers/acpi/sbs.c     |   25 -------------------------
>  4 files changed, 1 insertion(+), 68 deletions(-)
> 
> Index: linux-2.6/drivers/acpi/Kconfig
> ===================================================================
> --- linux-2.6.orig/drivers/acpi/Kconfig
> +++ linux-2.6/drivers/acpi/Kconfig
> @@ -66,7 +66,7 @@ config ACPI_PROCFS
>  config ACPI_PROCFS_POWER
>  	bool "Deprecated power /proc/acpi directories"
>  	depends on PROC_FS
> -	default y
> +	default n

"default n" is redundant, since Kconfig defaults to 'n'
when no default is specified.


> -config ACPI_SYSFS_POWER
> -	bool "Future power /sys interface"
> -	select POWER_SUPPLY

If we stop selecting POWER_SUPPLY here,
we become exposed to a build error:

drivers/built-in.o: In function `sysfs_remove_battery':
battery.c:(.text+0x5106e): undefined reference to 
`power_supply_unregister'
drivers/built-in.o: In function `acpi_battery_update':
battery.c:(.text+0x5162b): undefined reference to `power_supply_register'
drivers/built-in.o: In function `acpi_battery_notify':
battery.c:(.text+0x516ed): undefined reference to `power_supply_changed'


thanks,
Len Brown, Intel Open Source Technology Center