Re: [PATCH] acpi: remove dead code

[Len Brown <lenb@kernel.org>]

On Mon, 18 Oct 2010, Stephen Hemminger wrote:

> Found by running make namespacecheck on linux-next
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> 
> --- a/drivers/acpi/osl.c	2010-10-06 13:42:58.722974685 +0900
...
>  /*
> - * Allocate the memory for a spinlock and initialize it.
> - */
> -acpi_status acpi_os_create_lock(acpi_spinlock * handle)
> -{
> -	spin_lock_init(*handle);
> -
> -	return AE_OK;
> -}

ACPICA declares acpi_os_create_lock in acpiosxf.h,
but never calls it.  Bob, can we do away with it?

...
> -int acpi_check_mem_region(resource_size_t start, resource_size_t n,
> -		      const char *name)
> -{
> -	struct resource res = {
> -		.start = start,
> -		.end   = start + n - 1,
> -		.name  = name,
> -		.flags = IORESOURCE_MEM,
> -	};
> -
> -	return acpi_check_resource_conflict(&res);
> -
> -}
> -EXPORT_SYMBOL(acpi_check_mem_region);

acpi_check_mem_region seems to be entirely
a Linux thing.  It is exported to modules -- though
see any that use it.

> --- a/drivers/acpi/processor_driver.c	2010-10-06 13:46:52.594978592 +0900
...
> -EXPORT_SYMBOL(acpi_processor_set_thermal_limit);
...
> --- a/drivers/acpi/processor_thermal.c	2010-10-06 13:47:23.469979232 +0900
...
> -int acpi_processor_set_thermal_limit(acpi_handle handle, int type)
> -{

although acpi_processor_set_thermal_limit() is exported to modules
I don't see any users in recent history.


thanks,
-Len Brown, Intel Open Source Technology Center