From: Len Brown <lenb@kernel.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
Jan Beulich <jbeulich@novell.com>
Subject: Re: Wrong commit in the ACPI release branch
Date: Mon, 13 Dec 2010 15:11:20 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1012131507120.16730@x980> (raw)
In-Reply-To: <201012112329.35080.rjw@sisk.pl>
On Sat, 11 Dec 2010, Rafael J. Wysocki wrote:
> http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=commit;h=091aad6af4ab29af693ced5d6970ceee9d5981c8
>
> (ACPI: eliminate unused variable warning for !ACPI_SLEEP)
> is actually wrong, because it's going to break compilation for
> (!CONFIG_PM_SLEEP && CONFIG_PM_RUNTIME).
That's funny, that config builds for me.
It got through my 399 kernel build test, as well as linux-next.
If you have a .config that breaks, please send it to me.
> I haven't seen it before, let alone acking it or something like this, so I wonder
> why it's being pushed directly to Linus?
it fixes an unused variable warning if !CONFG_ACPI_SLEEP, per the commit
message.
thanks,
Len Brown, Intel Open Source Technology Center
prev parent reply other threads:[~2010-12-13 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-11 22:29 Wrong commit in the ACPI release branch Rafael J. Wysocki
2010-12-13 8:05 ` Jan Beulich
2010-12-13 21:09 ` Rafael J. Wysocki
2010-12-13 20:11 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1012131507120.16730@x980 \
--to=lenb@kernel.org \
--cc=jbeulich@novell.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox