From: Len Brown <lenb@kernel.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: LKML <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Renninger <trenn@suse.de>
Subject: Re: [PATCH] cpuidle: Make cpuidle_enable_device() call poll_idle_init()
Date: Mon, 10 Jan 2011 18:01:01 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.02.1101101754320.7945@x980> (raw)
In-Reply-To: <201101080029.20744.rjw@sisk.pl>
> /**
> * cpuidle_enable_device - enables idle PM for a CPU
> * @dev: the CPU
> @@ -176,6 +215,8 @@ int cpuidle_enable_device(struct cpuidle
> ret = __cpuidle_register_device(dev);
> if (ret)
> return ret;
> + } else {
> + poll_idle_init(dev);
> }
how about calling poll_idle_init() unconditionally here
and deleting the call to it from within __cpuidle_register_device()?
thanks,
Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-01-10 23:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 23:29 [PATCH] cpuidle: Make cpuidle_enable_device() call poll_idle_init() Rafael J. Wysocki
2011-01-10 22:49 ` Len Brown
2011-01-10 23:01 ` Len Brown [this message]
2011-01-11 0:02 ` Rafael J. Wysocki
2011-01-11 0:05 ` Rafael J. Wysocki
2011-01-11 9:37 ` Thomas Renninger
2011-01-11 20:52 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1101101754320.7945@x980 \
--to=lenb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox