From: Len Brown <lenb@kernel.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-acpi@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
akpm <akpm@linux-foundation.org>, Zhang Rui <rui.zhang@intel.com>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Zimny Lech <napohybelskurwysynom2010@gmail.com>
Subject: Re: on builds/randconfigs (was: [PATCH -next] thermal: depends on NET)
Date: Wed, 12 Jan 2011 13:35:10 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.02.1101121257580.18873@x980> (raw)
In-Reply-To: <4D2DE97C.2000205@oracle.com>
> > While I agree that randconfig build testing
> > is theoretically useful, in recent memory
> > its results do not seem particularly relevant
> > to useful configs.
>
> Who defines useful?
Simple.
Configs that will be used are useful.
Phantom configs that will NEVER be used are NOT useful.
Phantom configs are HARMFUL, as they squander
finite testing and maintainer resources
that should be applied to code that is actually used.
Rather than celebrating our theoretical flexibility
with every new config option, we should recoil at the
fact that each one may up to double the number of
configs that need to be tested and supported.
When I'm answering your nagging e-mail about a build failure
in a phantom config that nobody would even conceive of using,
I'm not using that time to fix somebody's real problem
on a real machine.
I'd rather see you spend your time making select work
to delete an entire category of Kconfig failures,
or simply adding dependencies making phantom configs impossible.
eg. Look in drivers/acpi/Kconfig:
menuconfig ACPI
bool "ACPI (Advanced Configuration and Power Interface) Support"
depends on !IA64_HP_SIM
depends on IA64 || X86
depends on PCI
depends on PM
select PNP
Does all of ACPI technically depend on PCI?
Does all of ACPI technically depend on PM support?
Does all of ACPI technically depend on configuration and PNP?
Theoretically, no.
Do I care about the phantom configs that would be possible
if these false dependencies were not in place. No,
not until somebody invents such a system,
and may be not even then.
Is there a user out there on LKML who can dream up
a use for one of these phantom configs and claim that
his life will end if he'd prevented from building it?
Sure. Does he suffer from a total lack of perspective?
Yes.
-Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-01-12 18:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101213163607.0b0a7c3a.sfr@canb.auug.org.au>
[not found] ` <20101213112033.d0060e6c.randy.dunlap@oracle.com>
2011-01-10 17:00 ` [PATCH -next] thermal: depends on NET Randy Dunlap
2011-01-12 5:18 ` Len Brown
2011-01-12 17:48 ` on builds/randconfigs (was: [PATCH -next] thermal: depends on NET) Randy Dunlap
2011-01-12 18:35 ` Len Brown [this message]
2011-01-12 18:38 ` on builds/randconfigs Randy Dunlap
2011-01-12 21:52 ` Len Brown
2011-01-12 21:18 ` on builds/randconfigs (was: [PATCH -next] thermal: depends on NET) Andrew Morton
2011-01-12 21:24 ` Rafael J. Wysocki
2011-01-12 21:58 ` Len Brown
2011-01-12 22:15 ` Valdis.Kletnieks
2011-01-12 22:54 ` on builds/randconfigs Randy Dunlap
2011-01-13 0:44 ` on builds/randconfigs (was: [PATCH -next] thermal: depends on NET) Stephen Rothwell
2011-01-13 3:31 ` Len Brown
2011-01-13 3:45 ` Steven Rostedt
2011-01-13 3:48 ` Stephen Rothwell
2011-01-13 4:08 ` Linus Torvalds
2011-01-13 12:23 ` on builds/randconfigs Michal Marek
2011-01-15 12:24 ` Vegard Nossum
2011-01-15 16:09 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1101121257580.18873@x980 \
--to=lenb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=napohybelskurwysynom2010@gmail.com \
--cc=randy.dunlap@oracle.com \
--cc=rui.zhang@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox