Re: [PATCH 1/4] X86: Revamp reboot behaviour to match Windows more closely

Len Brown
2011-03-23T03:49:22Z

> > > Does this fix a particular problem observed in practice?
> >
> > Yup. We're seeing an increasing number of machines that don't implement
> > the legacy keyboard controller at all and fail to reboot if you poke it.
> > The expectation appears to be that you use the ACPI reboot vector on
> > these machines.
>
> So perhaps you can put a pointer or two into the changelog? That would
> show precisely that it's not just for pure Windows compatibility.

We've been through this before -- many times, in fact.
There are lots of machines that reset only via ACPI,
but when we cut the default over to ACPI, we had
some regressions, and so that change was reverted.

The most recent round started off as a DMI workaround:
http://lkml.org/lkml/2010/1/3/56
and it almost went upstream, but the expected refreshed
patch never materialized.

I think that Matthew's approach is more thorough than
anything else we've tried before wrt compatibility.

But we've found this area to be somewhat fragile in the past,
and so if he succeeds in not breaking any machines,
Matthew is officially my hero:-)

thanks,
Len Brown, Intel Open Source Technology Center